Bug 1768684: Avoid console_url metric as empty string #346

benjaminapetersen · 2019-11-13T04:15:53Z

Ensure route.host has a value before tracking console_url metric to avoid the value "".

https://bugzilla.redhat.com/show_bug.cgi?id=1768684

openshift-ci-robot · 2019-11-13T04:15:56Z

@benjaminapetersen: This pull request references Bugzilla bug 1768684, which is invalid:

expected dependent Bugzilla bug 1764313 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1768684: Avoid console_url metric as empty string

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-11-13T04:16:12Z

/bugzilla refresh

openshift-ci-robot · 2019-11-13T04:16:14Z

@benjaminapetersen: This pull request references Bugzilla bug 1768684, which is invalid:

expected dependent Bugzilla bug 1764313 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-11-13T04:18:37Z

Hmm, didn't expect it to reference Bugzilla bug 1764313. This is fine.

jhadvig · 2019-11-13T10:33:18Z

pkg/console/operator/sync_v400.go

+	}
+	// if status.consoleURL is different than consoleURL,
+	// clear the old, then set new
+	if consoleConfig.Status.ConsoleURL != consoleURL {


will this ever be true? since this check is already done in SyncConsoleConfig() and is setting the consoleConfig.Status.ConsoleURL to consoleURL ?

pkg/console/operator/sync_v400.go

spadgett · 2019-11-13T16:10:26Z

/bugzilla refresh

openshift-ci-robot · 2019-11-13T16:10:33Z

@spadgett: This pull request references Bugzilla bug 1768684, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/console/metrics/metrics.go

spadgett · 2019-11-14T17:59:29Z

Looks like you have govet errors

pkg/console/metrics/console_url.go

benjaminapetersen · 2019-11-15T16:51:11Z

Removed the initialized bool & double checked gofmt. Should be good.

benjaminapetersen · 2019-11-15T19:19:59Z

 --- FAIL: TestRemoved (46.23s)

See #344 for a fix for this test, which adds 3x retries before reporting failure.

openshift-ci-robot · 2019-11-18T21:23:28Z

@benjaminapetersen: This pull request references Bugzilla bug 1768684, which is valid.

Details

In response to this:

Bug 1768684: Avoid console_url metric as empty string

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-11-18T21:24:11Z

This should now pass with the fix that went in with the downloads e2e.

jhadvig

nit and a question :)

pkg/console/transport/transport.go

…void ""

spadgett · 2019-11-19T15:21:02Z

error: received unexpected HTTP status: 500 Internal Server Error

/retest

spadgett

/lgtm

openshift-ci-robot · 2019-11-19T15:22:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-11-19T15:40:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-11-19T15:54:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-11-19T16:07:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-11-19T16:33:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-11-19T16:46:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-11-19T17:38:32Z

@benjaminapetersen: All pull requests linked via external trackers have merged. Bugzilla bug 1768684 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1768684: Avoid console_url metric as empty string

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-12-10T14:43:35Z

/cherry-pick release-4.2

openshift-cherrypick-robot · 2019-12-10T14:43:44Z

@benjaminapetersen: #346 failed to apply on top of branch "release-4.2":

error: mode change for pkg/console/metrics/metrics.go, which is not in current HEAD
error: could not build fake ancestor
Patch failed at 0001 Ensure route.host has a value before tracking console_url metric to avoid ""

Details

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-12-10T14:44:01Z

Manual it is :)

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 13, 2019

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2019

openshift-ci-robot requested review from jhadvig and spadgett November 13, 2019 04:16

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019

jhadvig requested changes Nov 13, 2019

View reviewed changes

benjaminapetersen force-pushed the bug/1768684/metric/console_url/empty-string branch 2 times, most recently from b9f7628 to 2873ec8 Compare November 13, 2019 16:06

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 13, 2019

benjaminapetersen commented Nov 13, 2019

View reviewed changes

pkg/console/metrics/metrics.go Show resolved Hide resolved

benjaminapetersen force-pushed the bug/1768684/metric/console_url/empty-string branch from 2873ec8 to 6a4bcb2 Compare November 13, 2019 16:55

spadgett reviewed Nov 13, 2019

View reviewed changes

pkg/console/metrics/metrics.go Outdated Show resolved Hide resolved

spadgett added this to the v4.3 milestone Nov 13, 2019

benjaminapetersen force-pushed the bug/1768684/metric/console_url/empty-string branch 2 times, most recently from 8810461 to e2c2f17 Compare November 13, 2019 18:29

spadgett reviewed Nov 14, 2019

View reviewed changes

pkg/console/metrics/console_url.go Outdated Show resolved Hide resolved

benjaminapetersen force-pushed the bug/1768684/metric/console_url/empty-string branch from e2c2f17 to ecb0748 Compare November 15, 2019 16:50

benjaminapetersen closed this Nov 18, 2019

benjaminapetersen reopened this Nov 18, 2019

benjaminapetersen force-pushed the bug/1768684/metric/console_url/empty-string branch from ecb0748 to ce44340 Compare November 19, 2019 03:33

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2019

jhadvig reviewed Nov 19, 2019

View reviewed changes

pkg/console/transport/transport.go Outdated Show resolved Hide resolved

pkg/console/transport/transport.go Outdated Show resolved Hide resolved

Ensure route.host has a value before tracking console_url metric to a…

dfc6b1e

…void ""

benjaminapetersen force-pushed the bug/1768684/metric/console_url/empty-string branch from ce44340 to dfc6b1e Compare November 19, 2019 15:03

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2019

spadgett approved these changes Nov 19, 2019

View reviewed changes

openshift-ci-robot assigned spadgett Nov 19, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2019

openshift-merge-robot merged commit 4037330 into openshift:master Nov 19, 2019

benjaminapetersen deleted the bug/1768684/metric/console_url/empty-string branch December 4, 2019 21:06

benjaminapetersen mentioned this pull request Dec 10, 2019

Bug 1781475: Avoid console_url metric as empty string [Release-4.2] #360

Closed

Bug 1768684: Avoid console_url metric as empty string #346

Bug 1768684: Avoid console_url metric as empty string #346

Uh oh!

Conversation

benjaminapetersen commented Nov 13, 2019

Uh oh!

openshift-ci-robot commented Nov 13, 2019

Uh oh!

benjaminapetersen commented Nov 13, 2019

Uh oh!

openshift-ci-robot commented Nov 13, 2019

Uh oh!

benjaminapetersen commented Nov 13, 2019

Uh oh!

jhadvig Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spadgett commented Nov 13, 2019

Uh oh!

openshift-ci-robot commented Nov 13, 2019

Uh oh!

Uh oh!

Uh oh!

spadgett commented Nov 14, 2019

Uh oh!

Uh oh!

benjaminapetersen commented Nov 15, 2019

Uh oh!

benjaminapetersen commented Nov 15, 2019

Uh oh!

openshift-ci-robot commented Nov 18, 2019

Uh oh!

benjaminapetersen commented Nov 18, 2019

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

spadgett commented Nov 19, 2019

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Nov 19, 2019

Uh oh!

openshift-bot commented Nov 19, 2019

Uh oh!

openshift-bot commented Nov 19, 2019

Uh oh!

openshift-bot commented Nov 19, 2019

Uh oh!

openshift-bot commented Nov 19, 2019

Uh oh!

openshift-bot commented Nov 19, 2019

Uh oh!

openshift-ci-robot commented Nov 19, 2019

Uh oh!

benjaminapetersen commented Dec 10, 2019

Uh oh!

openshift-cherrypick-robot commented Dec 10, 2019

Uh oh!

benjaminapetersen commented Dec 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

benjaminapetersen commented Dec 10, 2019 •

edited

Loading