Bug 1773808: Enable multi-arch support in downloads [4.2] #352

yselkowitz · 2019-11-20T15:38:23Z

In order for console-operator deployment to succeed, cli-artifacts needs to be available on all arches for downloads-openshift-console. However, in that case, /usr/bin/oc (inherited from cli) is a native binary, and we want to provide all primary Linux architectures to match those on mirror.openshift.com, regardless of cluster architecture.

This depends on openshift/oc#168 to provide the new binaries in cli-artifacts for 4.2.

This is a cherry-pick of the first commit from #343. The other commits from that PR are relevant only to new code in 4.3+.

In order for console-operator deployment to succeed, cli-artifacts needs to be available on all arches for downloads-openshift-console. However, in that case, /usr/bin/oc (inherited from cli) is a native binary, and we want to provide all primary Linux architectures to match those on mirror.openshift.com, regardless of cluster architecture. This depends on openshift/oc#153 to provide the new binaries in cli-artifacts. (cherry picked from commit 95d5e4b)

openshift-ci-robot · 2019-11-20T15:38:26Z

@yselkowitz: This pull request references Bugzilla bug 1773808, which is invalid:

expected dependent Bugzilla bug 1773807 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1773808: Enable multi-arch support in downloads [4.2]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-20T15:38:37Z

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz · 2019-11-20T15:39:00Z

/hold
until openshift/oc#168 is merged

yselkowitz · 2019-11-21T16:48:19Z

/bugzilla refresh

openshift-ci-robot · 2019-11-21T16:48:25Z

@yselkowitz: This pull request references Bugzilla bug 1773808, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crawford · 2019-11-26T19:43:06Z

/retest

crawford · 2019-11-26T19:43:24Z

/ok-to-test

yselkowitz · 2019-12-02T16:11:34Z

/retest

benjaminapetersen · 2019-12-02T20:07:30Z

/retest

 Dec  2 16:46:16.952: INFO:  > ERROR: (gcloud.compute.instance-groups.list-instances) could not parse resource []
Dec  2 16:46:16.952: INFO:  > 
Dec  2 16:46:16.952: INFO: Cluster image sources lookup failed: exit status 1

yselkowitz · 2019-12-03T03:55:01Z

/retest

yselkowitz · 2019-12-03T20:11:41Z

/hold cancel
/retest
openshift/oc#168 has been merged into 4.2.

yselkowitz · 2019-12-03T21:54:50Z

@benjaminapetersen prerequisite has been merged and CI on this has passed.

spadgett · 2019-12-04T15:57:49Z

/assign @benjaminapetersen

benjaminapetersen · 2019-12-04T15:59:35Z

/lgtm

openshift-ci-robot · 2019-12-04T16:00:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [benjaminapetersen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shawn-hurley · 2019-12-08T18:04:48Z

/bugzilla refresh

openshift-ci-robot · 2019-12-08T18:04:52Z

@shawn-hurley: This pull request references Bugzilla bug 1773808, which is invalid:

expected the bug to target the "4.2.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jaypoulz · 2019-12-09T19:25:09Z

/bugzilla refresh

openshift-ci-robot · 2019-12-09T19:25:12Z

@jaypoulz: This pull request references Bugzilla bug 1773808, which is invalid:

expected dependent Bugzilla bug 1781330 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz · 2019-12-09T19:34:13Z

/bugzilla refresh

openshift-ci-robot · 2019-12-09T19:34:17Z

@yselkowitz: This pull request references Bugzilla bug 1773808, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shawn-hurley · 2019-12-09T21:21:47Z

/bugzilla refresh

openshift-ci-robot · 2019-12-09T21:21:50Z

@shawn-hurley: This pull request references Bugzilla bug 1773808, which is invalid:

expected dependent Bugzilla bug 1781330 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eparis · 2019-12-09T21:34:53Z

/bugzilla refresh

openshift-ci-robot · 2019-12-09T21:34:56Z

@eparis: This pull request references Bugzilla bug 1773808, which is invalid:

expected dependent Bugzilla bug 1781330 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eparis · 2019-12-09T21:36:10Z

/bugzilla refresh

openshift-ci-robot · 2019-12-09T21:36:14Z

@eparis: This pull request references Bugzilla bug 1773808, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz · 2019-12-09T23:24:46Z

/test e2e-gcp

openshift-bot · 2019-12-09T23:50:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

yselkowitz · 2019-12-10T00:58:18Z

/test e2e-gcp

yselkowitz · 2019-12-10T02:31:44Z

/test e2e-gcp

openshift-bot · 2019-12-10T02:52:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-12-10T03:49:10Z

@yselkowitz: All pull requests linked via external trackers have merged. Bugzilla bug 1773808 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1773808: Enable multi-arch support in downloads [4.2]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 20, 2019

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2019

openshift-ci-robot requested review from benjaminapetersen and jhadvig November 20, 2019 15:39

benjaminapetersen self-assigned this Nov 20, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 21, 2019

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 21, 2019

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 8, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 9, 2019

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 9, 2019

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 9, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 9, 2019

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 9, 2019

shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 9, 2019

openshift-merge-robot merged commit c7f433d into openshift:release-4.2 Dec 10, 2019

Bug 1773808: Enable multi-arch support in downloads [4.2] #352

Bug 1773808: Enable multi-arch support in downloads [4.2] #352

Uh oh!

Conversation

yselkowitz commented Nov 20, 2019

Uh oh!

openshift-ci-robot commented Nov 20, 2019

Uh oh!

openshift-ci-robot commented Nov 20, 2019

Uh oh!

yselkowitz commented Nov 20, 2019

Uh oh!

yselkowitz commented Nov 21, 2019

Uh oh!

openshift-ci-robot commented Nov 21, 2019

Uh oh!

crawford commented Nov 26, 2019

Uh oh!

crawford commented Nov 26, 2019

Uh oh!

yselkowitz commented Dec 2, 2019

Uh oh!

benjaminapetersen commented Dec 2, 2019

Uh oh!

yselkowitz commented Dec 3, 2019

Uh oh!

yselkowitz commented Dec 3, 2019

Uh oh!

yselkowitz commented Dec 3, 2019

Uh oh!

spadgett commented Dec 4, 2019

Uh oh!

benjaminapetersen commented Dec 4, 2019

Uh oh!

openshift-ci-robot commented Dec 4, 2019

Uh oh!

shawn-hurley commented Dec 8, 2019

Uh oh!

openshift-ci-robot commented Dec 8, 2019

Uh oh!

jaypoulz commented Dec 9, 2019

Uh oh!

openshift-ci-robot commented Dec 9, 2019

Uh oh!

yselkowitz commented Dec 9, 2019

Uh oh!

openshift-ci-robot commented Dec 9, 2019

Uh oh!

shawn-hurley commented Dec 9, 2019

Uh oh!

openshift-ci-robot commented Dec 9, 2019

Uh oh!

eparis commented Dec 9, 2019

Uh oh!

openshift-ci-robot commented Dec 9, 2019

Uh oh!

eparis commented Dec 9, 2019

Uh oh!

openshift-ci-robot commented Dec 9, 2019

Uh oh!

yselkowitz commented Dec 9, 2019

Uh oh!

openshift-bot commented Dec 9, 2019

Uh oh!

yselkowitz commented Dec 10, 2019

Uh oh!

yselkowitz commented Dec 10, 2019

Uh oh!

openshift-bot commented Dec 10, 2019

Uh oh!

openshift-ci-robot commented Dec 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants