Bug 1773807: Enable all Linux arches in cli-artifacts [4.2] #168

yselkowitz · 2019-11-19T04:32:09Z

In order for console-operator deployment to succeed, cli-artifacts needs to be available on all arches for downloads-openshift-console. However, in that case, /usr/bin/oc (inherited from cli) is a native binary, and we want to provide all primary Linux architectures to match those on mirror.openshift.com.

In order to do so, this provides cross-compiled Linux binaries for multiple architectures. Cross-compiling oc fails with gssapi enabled, therefore it is disabled in the cross builds.

Cherry-pick of #153 to 4.2.

openshift-ci-robot · 2019-11-19T04:32:14Z

@yselkowitz: This pull request references Bugzilla bug 1773807, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1773807: Enable all Linux arches in cli-artifacts [4.2]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-19T04:32:23Z

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking

a41e4f9 is a clean cherry pick.

/ok-to-test
/lgtm

yselkowitz · 2019-11-19T12:11:44Z

/retest

yselkowitz · 2019-11-19T17:47:10Z

/retest

yselkowitz · 2019-11-19T21:17:31Z

/retest

yselkowitz · 2019-11-20T02:32:34Z

This passed CI on master. Is there actually a problem here or is CI just flaky (yet again)?

yselkowitz · 2019-11-20T15:57:33Z

/retest

yselkowitz · 2019-11-20T16:54:38Z

/hold
https://coreos.slack.com/archives/CEKNRGF25/p1574259886210100

In order for console-operator deployment to succeed, cli-artifacts needs to be available on all arches for downloads-openshift-console. However, in that case, /usr/bin/oc (inherited from cli) is a native binary, and we want to provide all primary Linux architectures to match those on mirror.openshift.com. In order to do so, this provides cross-compiled Linux binaries for multiple architectures. Cross-compiling oc fails with gssapi enabled, therefore it is disabled in the cross builds. (cherry picked from commit e949088) (squashed commit 2510f47)

yselkowitz · 2019-11-21T16:42:06Z

/hold cancel
squashed #171 to avoid breaking oc adm release extract

yselkowitz · 2019-11-21T18:19:30Z

/retest

yselkowitz · 2019-11-22T00:56:57Z

/test unit
/test e2e-cmd

yselkowitz · 2019-11-22T15:39:31Z

/test unit
/test e2e-cmd

yselkowitz · 2019-11-25T18:17:32Z

/retest

yselkowitz · 2019-11-25T18:39:20Z

This passed CI on master. Is there actually a problem here or is CI just flaky (yet again)?

Ping?

crawford · 2019-11-26T19:32:31Z

/retest

crawford · 2019-11-26T19:40:18Z

@yselkowitz it appears as though the unit tests are routinely failing:

FAIL: github.com/openshift/oc/pkg/helpers/newapp/newapptest TestNewAppRunAll/successful_docker_app_generation 1.4s
FAIL: github.com/openshift/oc/pkg/helpers/newapp/newapptest TestNewAppRunAll/Docker_build 910ms
FAIL: github.com/openshift/oc/pkg/helpers/newapp/newapptest TestNewAppRunAll/Docker_build_with_no_registry_image 1.06s
FAIL: github.com/openshift/oc/pkg/helpers/newapp/newapptest TestNewAppRunAll 11.93s
FAIL: github.com/openshift/oc/pkg/helpers/newapp/newapptest TestNewAppRunBuilds/successful_input_image_source_build_with_a_repository 1.61s
FAIL: github.com/openshift/oc/pkg/helpers/newapp/newapptest TestNewAppRunBuilds 12.22s

wking · 2019-11-26T19:49:48Z

From unit:

set -o pipefail; go test -race -json ./... ./vendor/k8s.io/kubernetes/pkg/kubectl/... | gotest2junit > /tmp/artifacts/unit_report.xml

So check the report?

yselkowitz · 2019-11-26T21:10:35Z

Thanks for the pointer. #158 should fix the unit test but is currently blocked, and it is noted there that e2e-cmd is failing there as well. Since those issues should be unrelated to this PR, how should we proceed?

yselkowitz · 2019-12-02T16:11:25Z

/retest

yselkowitz · 2019-12-02T17:54:13Z

CI blocked by #195, can we please either get that fixed or this waived?

crawford · 2019-12-02T21:26:27Z

@yselkowitz We're going to get #195 merged soon. I'll kick off the tests again once that happens.

crawford · 2019-12-02T21:51:02Z

/retest

crawford · 2019-12-02T22:05:01Z

/lgtm
/approve

yselkowitz · 2019-12-02T23:59:24Z

/assign @mfojtik

soltysh

/lgtm
/approve
/retest

openshift-ci-robot · 2019-12-03T13:54:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, soltysh, wking, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yselkowitz · 2019-12-03T16:51:53Z

@soltysh thanks for approval. Testing has completed but it looks like /cherry-pick-approved is stil needed for this to merge.

soltysh · 2019-12-03T17:15:44Z

@soltysh thanks for approval. Testing has completed but it looks like /cherry-pick-approved is stil needed for this to merge.

That is correct patch-manager will apply one when going through approved PRs.

crawford · 2019-12-03T18:15:25Z

From the failure:

Error waiting for instance (i-0e84164cc2fa1f74a) to become ready: Failed to reach target state. Reason: Server.InternalError: Internal error on launch

/retest

openshift-bot · 2019-12-03T18:19:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-12-03T19:44:55Z

@yselkowitz: All pull requests linked via external trackers have merged. Bugzilla bug 1773807 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1773807: Enable all Linux arches in cli-artifacts [4.2]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 19, 2019

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2019

openshift-ci-robot requested review from mfojtik and soltysh November 19, 2019 04:32

openshift-ci-robot assigned wking Nov 19, 2019

wking approved these changes Nov 19, 2019

View reviewed changes

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2019

wking mentioned this pull request Nov 19, 2019

Enable multi-arch support in downloads openshift/console-operator#343

Merged

yselkowitz mentioned this pull request Nov 20, 2019

Bug 1773808: Enable multi-arch support in downloads [4.2] openshift/console-operator#352

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2019

yselkowitz force-pushed the release-4.2 branch from a41e4f9 to 913c34c Compare November 21, 2019 16:40

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2019

openshift-ci-robot assigned crawford Dec 2, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019

openshift-ci-robot assigned mfojtik Dec 2, 2019

soltysh approved these changes Dec 3, 2019

View reviewed changes

openshift-ci-robot assigned soltysh Dec 3, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019

crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 3, 2019

openshift-merge-robot merged commit 4ac9078 into openshift:release-4.2 Dec 3, 2019

yselkowitz deleted the release-4.2 branch July 5, 2022 22:59

Bug 1773807: Enable all Linux arches in cli-artifacts [4.2] #168

Bug 1773807: Enable all Linux arches in cli-artifacts [4.2] #168

Uh oh!

Conversation

yselkowitz commented Nov 19, 2019

Uh oh!

openshift-ci-robot commented Nov 19, 2019

Uh oh!

openshift-ci-robot commented Nov 19, 2019

Uh oh!

wking left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yselkowitz commented Nov 19, 2019

Uh oh!

yselkowitz commented Nov 19, 2019

Uh oh!

yselkowitz commented Nov 19, 2019

Uh oh!

yselkowitz commented Nov 20, 2019

Uh oh!

yselkowitz commented Nov 20, 2019

Uh oh!

yselkowitz commented Nov 20, 2019

Uh oh!

yselkowitz commented Nov 21, 2019

Uh oh!

yselkowitz commented Nov 21, 2019

Uh oh!

yselkowitz commented Nov 22, 2019

Uh oh!

yselkowitz commented Nov 22, 2019

Uh oh!

yselkowitz commented Nov 25, 2019

Uh oh!

yselkowitz commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crawford commented Nov 26, 2019

Uh oh!

crawford commented Nov 26, 2019

Uh oh!

wking commented Nov 26, 2019

Uh oh!

yselkowitz commented Nov 26, 2019

Uh oh!

yselkowitz commented Dec 2, 2019

Uh oh!

yselkowitz commented Dec 2, 2019

Uh oh!

crawford commented Dec 2, 2019

Uh oh!

crawford commented Dec 2, 2019

Uh oh!

crawford commented Dec 2, 2019

Uh oh!

yselkowitz commented Dec 2, 2019

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Dec 3, 2019

Uh oh!

yselkowitz commented Dec 3, 2019

Uh oh!

soltysh commented Dec 3, 2019

Uh oh!

crawford commented Dec 3, 2019

Uh oh!

openshift-bot commented Dec 3, 2019

Uh oh!

openshift-ci-robot commented Dec 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

wking left a comment •

edited

Loading

yselkowitz commented Nov 25, 2019 •

edited

Loading