Skip to content

[release-4.2] Bug 1771420: Update ruby-22-centos7 to ruby-25-centos7 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-4.2] Bug 1771420: Update ruby-22-centos7 to ruby-25-centos7 #158

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 12, 2019

This is an automated cherry-pick of #152

/assign soltysh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2019

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.2] Update ruby-22-centos7 to ruby-25-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 12, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2019
@soltysh soltysh changed the title [release-4.2] Update ruby-22-centos7 to ruby-25-centos7 [release-4.2] Bug 1771420: Update ruby-22-centos7 to ruby-25-centos7 Nov 12, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1771420, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.2] Bug 1771420: Update ruby-22-centos7 to ruby-25-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 12, 2019
soltysh
soltysh approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@soltysh soltysh mentioned this pull request Nov 12, 2019
Merged
@adambkaplan
Copy link
Contributor

adambkaplan commented Nov 12, 2019

/retest

1 similar comment
@adambkaplan
Copy link
Contributor

adambkaplan commented Nov 12, 2019

/retest

@soltysh
Copy link
Contributor

soltysh commented Nov 12, 2019

This requires openshift/origin#24109 to land first.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor

adambkaplan commented Nov 14, 2019

/hold

@soltysh looks like the oc update needs to be here as well. Has @sallyom's PR picked this up?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2019
@adambkaplan
Copy link
Contributor

adambkaplan commented Nov 14, 2019

@soltysh disregard - thought this was my PR cherrypick :/

@sallyom sallyom mentioned this pull request Nov 14, 2019
Merged
@soltysh
Copy link
Contributor

soltysh commented Nov 18, 2019

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor

adambkaplan commented Nov 20, 2019

/hold

e2e-cmd is consistently failing

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2019
@yselkowitz yselkowitz mentioned this pull request Nov 26, 2019
Merged
@soltysh
Copy link
Contributor

soltysh commented Nov 27, 2019

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 27, 2019

@openshift-cherrypick-robot: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-cmd 30bccf3 link /test e2e-cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor

soltysh commented Dec 2, 2019

/retest

@soltysh
Copy link
Contributor

soltysh commented Dec 2, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor

adambkaplan commented Dec 2, 2019

/hold

Looks like something is breaking that is preventing the test from running in the first place

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019
@soltysh
Copy link
Contributor

soltysh commented Dec 2, 2019

Looks like something is breaking that is preventing the test from running in the first place

What the heck this is trying to retest if everything else is green 🤷‍♂️

@soltysh soltysh mentioned this pull request Dec 2, 2019
Merged
@soltysh
Copy link
Contributor

soltysh commented Dec 2, 2019

closing in favour #195

@soltysh soltysh closed this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@tnozicka tnozicka Awaiting requested review from tnozicka

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @adambkaplan @soltysh @openshift-bot