Skip to content

Bug 1770741: Fixed Dockerfile FROM statement parser. #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 6, 2019
Merged

Bug 1770741: Fixed Dockerfile FROM statement parser. #154

openshift-merge-robot merged 1 commit into from
Dec 6, 2019

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 8, 2019

This is an automated cherry-pick of #136

/assign ricardomaraschini

@ricardomaraschini
Fixed Dockerfile FROM statement parser.
016d7da 
In some cases the FROM statement on a Dockerfile may contain an extra
alias, e.g.:

FROM fedora:latest AS builder

This commit fixes the parser to use only the second parsed node on the
FROM statement(on this case "fedora:latest") instead of returning the
last one(on this case "builder").
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 8, 2019
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1759920, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.2] Bug 1759920: Fixed Dockerfile FROM statement parser.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2019
@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 11, 2019

/retitle Bug 1770741: Fixed Dockerfile FROM statement parser.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.2] Bug 1759920: Fixed Dockerfile FROM statement parser. Bug 1770741: Fixed Dockerfile FROM statement parser. Nov 11, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1770741, which is invalid:

  • expected dependent Bugzilla bug 1759920 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1770741: Fixed Dockerfile FROM statement parser.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 11, 2019

/test unit

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 11, 2019

/test e2e-cmd

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 11, 2019

/test unit

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 11, 2019

@soltysh Hey, it seems like we still have problems on the CI[1] but now for branch release-4.2.

[1] #136 (comment)

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 12, 2019

/assign @adambkaplan @dmage

@soltysh
Copy link
Contributor

soltysh commented Nov 12, 2019

#158 should be the fix

soltysh
soltysh approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 15, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2019
@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 15, 2019

@soltysh It seems like the tests are not yet working properly. Would you mind checking it? As far as I could see the problem is still the same.

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 17, 2019

/retest

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 18, 2019

/test e2e-cmd

@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Nov 19, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 19, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2019

@ricardomaraschini: This pull request references Bugzilla bug 1770741, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

adambkaplan commented Nov 20, 2019

/retest

1 similar comment
@ricardomaraschini
Copy link
Contributor

ricardomaraschini commented Dec 3, 2019

/retest

@soltysh
Copy link
Contributor

soltysh commented Dec 3, 2019

This is good for merge now.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@shawn-hurley shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 6, 2019
@openshift-merge-robot openshift-merge-robot merged commit 98a84c6 into openshift:release-4.2 Dec 6, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2019

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1770741 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1770741: Fixed Dockerfile FROM statement parser.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmage dmage

@soltysh soltysh

@ricardomaraschini ricardomaraschini

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @ricardomaraschini @soltysh @openshift-bot @adambkaplan @dmage @shawn-hurley @openshift-merge-robot