Bug 1759920: Fixed Dockerfile FROM statement parser. #136
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@ricardomaraschini: This pull request references Bugzilla bug 1759920, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
size/S
In some cases the FROM statement on a Dockerfile may contain an extra alias, e.g.: FROM fedora:latest AS builder This commit fixes the parser to use only the second parsed node on the FROM statement(on this case "fedora:latest") instead of returning the last one(on this case "builder").
ricardomaraschini
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @adambkaplan @dmage |
|
/cherrypick release-4.2 |
|
@ricardomaraschini: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.1 |
|
@ricardomaraschini: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-builds |
|
@ricardomaraschini note that once this lands, we should update our multistage Dockerfile test suites to use FROM aliases. |
|
/lgtm |
|
/hold Need to add the build suite to this repo |
openshift-ci-robot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, dmage, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
openshift/release#5707 added builds and from what I see it's green. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
@ricardomaraschini also note that builds will be broken until openshift/origin#24100 lands (currently in merge pool) |
|
@adambkaplan yeah, I had a chat with @soltysh this morning. Thanks. |
|
/retest Builds should be unblocked now |
|
/test unit |
|
#152 merged |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
@ricardomaraschini: All pull requests linked via external trackers have merged. Bugzilla bug 1759920 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ricardomaraschini: new pull request created: #154 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ricardomaraschini: cannot checkout release-4.1: error checking out release-4.1: exit status 1. output: error: pathspec 'release-4.1' did not match any file(s) known to git. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.3 |
|
@ricardomaraschini: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.3 and openshift-cherrypick-robot:cherry-pick-136-to-release-4.3"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
In some cases the FROM statement on a Dockerfile may contain an extra
alias, e.g.:
FROM fedora:latest AS builder
This commit fixes the parser to use only the second parsed node on the
FROM statement(on this case "fedora:latest") instead of returning the
last one(on this case "builder").