Skip to content

Conversation

@adambkaplan
Copy link
Contributor

Ensure that changes to oc *build* commands and oc new-app don't break builds.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2019
@adambkaplan
Copy link
Contributor Author

/assign @mfojtik
/cc @soltysh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only run if build-related and new-app packages are changed. We can add others in the future if we deem necessary.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be pkg/.*build.* and pkg/.*newapp.*

@adambkaplan
Copy link
Contributor Author

fyi @ricardomaraschini

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be pkg/.*build.* and pkg/.*newapp.*

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

- Run build suite for any .*build.* package change (startbuild, newbuild, etc.)
- Run build suite for any new-app change.
@adambkaplan
Copy link
Contributor Author

@soltysh fixed rexexp

@openshift-ci-robot
Copy link
Contributor

@adambkaplan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/oc/release-4.4/e2e-aws-builds 28c3ad7 link /test pj-rehearse
ci/prow/pj-rehearse 28c3ad7 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1e5e732 into openshift:master Oct 31, 2019
@openshift-ci-robot
Copy link
Contributor

@adambkaplan: Updated the following 9 configmaps:

  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-oc-master.yaml using file ci-operator/config/openshift/oc/openshift-oc-master.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-oc-release-4.3.yaml using file ci-operator/config/openshift/oc/openshift-oc-release-4.3.yaml
  • ci-operator-4.4-configs configmap in namespace ci using the following files:
    • key openshift-oc-release-4.4.yaml using file ci-operator/config/openshift/oc/openshift-oc-release-4.4.yaml
  • ci-operator-4.4-configs configmap in namespace ci-stg using the following files:
    • key openshift-oc-release-4.4.yaml using file ci-operator/config/openshift/oc/openshift-oc-release-4.4.yaml
  • job-config-master configmap in namespace ci using the following files:
    • key openshift-oc-master-presubmits.yaml using file ci-operator/jobs/openshift/oc/openshift-oc-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-oc-master.yaml using file ci-operator/config/openshift/oc/openshift-oc-master.yaml
  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-oc-release-4.3.yaml using file ci-operator/config/openshift/oc/openshift-oc-release-4.3.yaml
  • job-config-4.3 configmap in namespace ci using the following files:
    • key openshift-oc-release-4.3-presubmits.yaml using file ci-operator/jobs/openshift/oc/openshift-oc-release-4.3-presubmits.yaml
  • job-config-4.4 configmap in namespace ci using the following files:
    • key openshift-oc-release-4.4-presubmits.yaml using file ci-operator/jobs/openshift/oc/openshift-oc-release-4.4-presubmits.yaml
Details

In response to this:

Ensure that changes to oc *build* commands and oc new-app don't break builds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants