Skip to content

Update ruby-22-centos7 to ruby-25-centos7 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 8, 2019
Merged

Update ruby-22-centos7 to ruby-25-centos7 #152

openshift-merge-robot merged 1 commit into from
Nov 8, 2019

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Nov 7, 2019

Similarly how in openshift/origin#24100 change deprecated ruby-22-centos7 instances.

/assign @adambkaplan

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
adambkaplan
adambkaplan approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Nov 7, 2019

Fix single place where openshift/ruby-25-centos7 was specified instead of centos/ruby-25-centos7 selftagging to unblock queue.

@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@adambkaplan
Copy link
Contributor

adambkaplan commented Nov 7, 2019

/retest

1 similar comment
@adambkaplan
Copy link
Contributor

adambkaplan commented Nov 8, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 77aea3e into openshift:master Nov 8, 2019
This was referenced Nov 8, 2019
Merged
Merged
@soltysh soltysh deleted the fix_ruby branch November 8, 2019 16:38
@soltysh soltysh mentioned this pull request Nov 12, 2019
Merged
@soltysh
Copy link
Contributor Author

soltysh commented Nov 12, 2019

/cherrypick release-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 12, 2019
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 12, 2019

@soltysh: new pull request created: #158

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@soltysh @openshift-ci-robot @adambkaplan @openshift-cherrypick-robot @openshift-merge-robot