Bug 1859331: manifests/07-downloads-deployment: Create index.html by wking · Pull Request #457 · openshift/console-operator

wking · 2020-08-14T22:08:09Z

Conservative, filesystem-based web servers should avoid dynamic directory listing, to avoid accidentally leaking a file that a user drops into the served filesystem. It seems like an unlikely vector for the downloads container, where nobody outside of our script is likely to be dropping files. But it is easy enough to fix by filling in index.html files throughout, which preempt SimpleHTTPRequestHandler's directory listing.

openshift-ci-robot · 2020-08-14T22:09:04Z

@wking: This pull request references Bugzilla bug 1859331, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859331: manifests/07-downloads-deployment: Create index.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-08-14T22:10:03Z

@wking: This pull request references Bugzilla bug 1859331, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859331: manifests/07-downloads-deployment: Create index.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig

Thanks @wking for this fix 👍

/lgtm

openshift-bot · 2020-08-17T10:59:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-17T11:25:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-17T15:06:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-17T15:32:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-17T19:39:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-17T22:27:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-17T23:32:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T00:50:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T02:21:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T03:52:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T04:05:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T09:04:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T09:17:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T11:27:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T14:16:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T16:26:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T19:54:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-19T01:19:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-20T11:33:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-20T13:56:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-20T16:47:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-20T18:29:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-08-20T18:44:38Z

/hold

This seems to be consistently failing with

[sig-arch] Managed cluster should have no crashlooping pods in core namespaces over four minutes [Suite:openshift/conformance/parallel] expand_more

Conservative, filesystem-based web servers should avoid dynamic directory listing, to avoid accidentally leaking a file that a user drops into the served filesystem [1,2]. It seems like an unlikely vector for the downloads container, where nobody outside of our script is likely to be dropping files. But it is easy enough to fix by filling in index.html files throughout, which preempt SimpleHTTPRequestHandler's directory listing [3,4]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1859331 [2]: https://cwe.mitre.org/data/definitions/548.html [3]: https://docs.python.org/2.7/library/simplehttpserver.html#SimpleHTTPServer.SimpleHTTPRequestHandler.do_GET [4]: https://github.com/python/cpython/blob/e7c98f08e228e9f6e139d61e3e5d0a5018a38f0b/Lib/http/server.py#L757-L758

wking · 2020-08-20T19:57:11Z

Ah, thanks. The few I'd spot checked had died in install or other unrelated flakes, but this job has the crashlooping downloads pod with a syntax error. Fixed a missing close-paren with affd465 -> e192af5.

wking · 2020-08-20T20:03:04Z

unit:

   * failed to generate steps from config: unable to create end to end test step: the embedded template is invalid: error converting YAML to JSON: yaml: line 155: found a tab character where an indentation space is expected
time="2020-08-20T19:57:14Z" level=info msg="Reporting job state 'failed' with reason 'defaulting_config'"

Dunno what that's about.

wking · 2020-08-20T20:12:23Z

openshift/ci-tools#1135 will fix CI. I expect the retest bot will be around to kick us once that is live.

spadgett · 2020-08-20T20:14:18Z

/hold cancel

wking · 2020-08-21T13:45:16Z

/retest

wking · 2020-08-21T22:39:47Z

/retest

jhadvig · 2020-08-24T08:01:26Z

/test e2e-gcp-upgrade

jhadvig · 2020-08-25T13:51:55Z

/test e2e-gcp-upgrade

jhadvig

/lgtm
/approve

openshift-ci-robot · 2020-08-25T13:53:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-08-25T19:26:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-25T20:29:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-25T21:08:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-25T23:58:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-08-26T01:05:03Z

@wking: All pull requests linked via external trackers have merged:

openshift/console-operator#457

Bugzilla bug 1859331 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1859331: manifests/07-downloads-deployment: Create index.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig · 2020-08-26T08:19:19Z

/test e2e-gcp-upgrade

openshift-ci-robot requested review from jhadvig and spadgett August 14, 2020 22:08

wking changed the title ~~manifests/07-downloads-deployment: Create index.html~~ Bug 1859331: manifests/07-downloads-deployment: Create index.html Aug 14, 2020

openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 14, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 14, 2020

wking force-pushed the downloads-directory-listing branch from c932f56 to affd465 Compare August 14, 2020 22:09

jhadvig approved these changes Aug 17, 2020

View reviewed changes

openshift-ci-robot assigned jhadvig Aug 17, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2020

wking force-pushed the downloads-directory-listing branch from affd465 to e192af5 Compare August 20, 2020 19:56

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2020

jhadvig approved these changes Aug 25, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020

openshift-merge-robot merged commit 93cd487 into openshift:master Aug 26, 2020

wking deleted the downloads-directory-listing branch August 26, 2020 13:51

openshift-ci-robot mentioned this pull request Aug 31, 2020

Bug 1859331: Fix downloads index #464

Merged

Conversation

wking commented Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 14, 2020

Uh oh!

openshift-ci-robot commented Aug 14, 2020

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Aug 17, 2020

Uh oh!

openshift-bot commented Aug 17, 2020

Uh oh!

openshift-bot commented Aug 17, 2020

Uh oh!

openshift-bot commented Aug 17, 2020

Uh oh!

openshift-bot commented Aug 17, 2020

Uh oh!

openshift-bot commented Aug 17, 2020

Uh oh!

openshift-bot commented Aug 17, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 18, 2020

Uh oh!

openshift-bot commented Aug 19, 2020

Uh oh!

openshift-bot commented Aug 20, 2020

Uh oh!

openshift-bot commented Aug 20, 2020

Uh oh!

openshift-bot commented Aug 20, 2020

Uh oh!

openshift-bot commented Aug 20, 2020

Uh oh!

spadgett commented Aug 20, 2020

Uh oh!

wking commented Aug 20, 2020

Uh oh!

wking commented Aug 20, 2020

Uh oh!

wking commented Aug 20, 2020

Uh oh!

spadgett commented Aug 20, 2020

Uh oh!

wking commented Aug 21, 2020

Uh oh!

wking commented Aug 21, 2020

Uh oh!

jhadvig commented Aug 24, 2020

Uh oh!

jhadvig commented Aug 25, 2020

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Aug 25, 2020

Uh oh!

openshift-bot commented Aug 25, 2020

Uh oh!

wking commented Aug 14, 2020 •

edited

Loading