Skip to content

Bug 1859331: Fix downloads index#464

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
multi-arch:master
Aug 31, 2020
Merged

Bug 1859331: Fix downloads index#464
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
multi-arch:master

Conversation

@yselkowitz
Copy link
Copy Markdown
Contributor

@yselkowitz yselkowitz commented Aug 28, 2020

The variable root is left over from the previous for loop, it shouldn't
be used again here.

/assign @wking

@yselkowitz
Fix downloads index
dab5d55 
The variable root is left over from the previous for loop, it shouldn't
be used again here.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 28, 2020

@yselkowitz: This pull request references Bugzilla bug 1859331, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1859331: Fix downloads index

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 28, 2020
@wking
Copy link
Copy Markdown
Member

wking commented Aug 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@wking wking mentioned this pull request Aug 28, 2020
Merged
@mfojtik
Copy link
Copy Markdown

mfojtik commented Aug 29, 2020

/approve

spadgett
spadgett approved these changes Aug 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@spadgett
Copy link
Copy Markdown
Member

spadgett commented Aug 29, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2020
@yselkowitz
Copy link
Copy Markdown
Contributor Author

yselkowitz commented Aug 30, 2020

/retest

jhadvig
jhadvig approved these changes Aug 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, mfojtik, spadgett, wking, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Aug 31, 2020

/test e2e-gcp

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 178cd78 into openshift:master Aug 31, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 31, 2020

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1859331 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1859331: Fix downloads index

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig jhadvig approved these changes

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yselkowitz @openshift-ci-robot @wking @mfojtik @spadgett @jhadvig @openshift-bot @openshift-merge-robot