Bug 1873414: Move deployment script to python3 by yselkowitz · Pull Request #463 · openshift/console-operator

yselkowitz · 2020-08-28T12:52:47Z

No description provided.

openshift-ci-robot · 2020-08-28T12:52:53Z

@yselkowitz: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1872080: Move deployment script to python3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2020-08-28T13:04:22Z

/assign @jhadvig @wking

openshift-ci-robot · 2020-08-28T14:01:37Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yselkowitz
To complete the pull request process, please assign jhadvig
You can assign the PR to them by writing /assign @jhadvig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This is used by the downloads-deployment serve.py script: openshift/console-operator#463

openshift-ci-robot · 2020-08-28T14:24:13Z

@yselkowitz: This pull request references Bugzilla bug 1873414, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1873414: Move deployment script to python3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jupierce · 2020-08-28T14:25:09Z

/test unit

yselkowitz · 2020-08-28T14:26:28Z

openshift/oc#538 probably needs to land first for CI to pass.

yselkowitz · 2020-08-28T15:34:09Z

openshift/images#34 needs to land first for CI to pass here.

jupierce · 2020-08-28T16:25:33Z

/retest

yselkowitz · 2020-08-28T17:42:54Z

/retest

jupierce · 2020-08-28T18:09:06Z

/test e2e-gcp

wking · 2020-08-28T20:17:31Z

                  write_index(
                      path=os.path.join(root, directory, 'index.html'),
-                      message='<p>Directory listings are disabled.  See <a href="">here</a> for available content.</p>'.format(root_link),
+                      message='<p>Directory listings are disabled.  See <a href="{}">here</a> for available content.</p>'.format(root_link),


Unrelated, but thanks for this fix :)

Found this testing the script with python3, but yes, it was broken before too. The root index.html still doesn't work as intended though, nor did it before, but I'm not sure how to fix it yet. (Nothing to do with this PR though.)

@spadgett something to potentially clean up in the future

#464 has the remaining cleanup

wking · 2020-08-28T20:19:57Z

still no python3?

wking · 2020-08-28T20:38:43Z

@jupierce removed the ci-op-633tn047 project, which may have cached stale images. Testing again (hopefully with freshly-built images):

/retest

openshift-ci-robot · 2020-08-28T21:57:34Z

@yselkowitz: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-upgrade	`28ad134`	link	`/test e2e-gcp-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jupierce · 2020-08-28T22:10:02Z

/retest

bparees · 2020-08-28T22:17:24Z

passed everything that matters, merging to unblock CI.

openshift-ci-robot · 2020-08-28T22:17:35Z

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1873414 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1873414: Move deployment script to python3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 28, 2020

openshift-ci-robot requested review from jhadvig and spadgett August 28, 2020 12:53

openshift-ci-robot assigned jhadvig and wking Aug 28, 2020

spadgett mentioned this pull request Aug 28, 2020

manifests: move downloads deployment to use python3 #462

Closed

spadgett reviewed Aug 28, 2020

View reviewed changes

Comment thread Dockerfile.rhel7 Outdated

yselkowitz force-pushed the master branch from dba7bbe to a26134d Compare August 28, 2020 14:01

yselkowitz added a commit to multi-arch/oc that referenced this pull request Aug 28, 2020

cli-artifacts: install python3 for downloads-deployment

f4d3684

This is used by the downloads-deployment serve.py script: openshift/console-operator#463

yselkowitz mentioned this pull request Aug 28, 2020

cli-artifacts: install python3 for downloads-deployment openshift/oc#538

Closed

yselkowitz changed the title ~~Bug 1872080: Move deployment script to python3~~ Bug 1873414: Move deployment script to python3 Aug 28, 2020

openshift-ci-robot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 28, 2020

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Aug 28, 2020

openshift-ci-robot mentioned this pull request Aug 28, 2020

Bug 1873414: Install python3 in ubi8 base to emulate ubi7 openshift/images#34

Merged

Move deployment script to python3

28ad134

yselkowitz force-pushed the master branch from a26134d to 28ad134 Compare August 28, 2020 18:24

wking reviewed Aug 28, 2020

View reviewed changes

bparees merged commit 0fdf391 into openshift:master Aug 28, 2020

Conversation

yselkowitz commented Aug 28, 2020

Uh oh!

openshift-ci-robot commented Aug 28, 2020

Uh oh!

spadgett commented Aug 28, 2020

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 28, 2020

Uh oh!

openshift-ci-robot commented Aug 28, 2020

Uh oh!

jupierce commented Aug 28, 2020

Uh oh!

yselkowitz commented Aug 28, 2020

Uh oh!

yselkowitz commented Aug 28, 2020

Uh oh!

jupierce commented Aug 28, 2020

Uh oh!

yselkowitz commented Aug 28, 2020

Uh oh!

jupierce commented Aug 28, 2020

Uh oh!

wking Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

yselkowitz Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

bparees Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

wking Aug 28, 2020

Choose a reason for hiding this comment

Uh oh!

wking commented Aug 28, 2020

Uh oh!

wking commented Aug 28, 2020

Uh oh!

openshift-ci-robot commented Aug 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jupierce commented Aug 28, 2020

Uh oh!

bparees commented Aug 28, 2020

Uh oh!

openshift-ci-robot commented Aug 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci-robot commented Aug 28, 2020 •

edited

Loading