Bug 1873414: Install python3 in ubi8 base to emulate ubi7#34
Bug 1873414: Install python3 in ubi8 base to emulate ubi7#34bparees merged 1 commit intoopenshift:masterfrom
Conversation
|
/lgtm |
|
@yselkowitz: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jupierce, yselkowitz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retitle Bug 1873414: Install python3 in ubi8 base to emulate ubi7 |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
@jupierce: This pull request references Bugzilla bug 1873414, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@jupierce: This pull request references Bugzilla bug 1873414, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Is this trying to be built as both base-7 and base-8?? The alternatives would probably only work on 8. |
| if [ ! -e /usr/bin/yum ]; then ln -s /usr/bin/microdnf /usr/bin/yum; fi && \ | ||
| echo 'skip_missing_names_on_install=0' >> /etc/yum.conf && \ | ||
| yum install -y --setopt=tsflags=nodocs ${INSTALL_PKGS} && \ | ||
| alternatives --set python /usr/bin/python3 && \ |
There was a problem hiding this comment.
If this needs to be buildable for both 7 and 8 (ugh, why?), then something like:
( test -e /usr/bin/python || alternatives --set python /usr/bin/python3) && \
There was a problem hiding this comment.
ugh, but that would mean that we're installing python3 alongside python2 in base-7
jupierce
force-pushed
the
python3_in_base
branch
from
b660140 to
e625592
Compare
| if [ ! -e /usr/bin/yum ]; then ln -s /usr/bin/microdnf /usr/bin/yum; fi && \ | ||
| echo 'skip_missing_names_on_install=0' >> /etc/yum.conf && \ | ||
| yum install -y --setopt=tsflags=nodocs ${INSTALL_PKGS} && \ | ||
| ( test -e /usr/bin/python || ( yum install -y --setopt=tsflags=nodocs python3 && alternatives --set python /usr/bin/python3 ) ) && \ |
jupierce
force-pushed
the
python3_in_base
branch
from
e625592 to
aaeb436
Compare
|
/test e2e-aws-upgrade |
|
hard to see how this makes things worse. merging and we can quick revert if i'm wrong. |
|
@jupierce: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1873414 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
ubi7 had python2 available for direct user consumption by default. ubi8 dropped this and instead has python3 installed, but only available internally for utilities like yum. By explicitly installing it here, we hope to satisfy the older assumptions layered images have on the openshift base.
Layered images that have python2 specific code will need to modify that code (recommended) or explicitly install python2 in their Dockerfile and use
alternativesto make it their default.