Bug 2023356: Devfiles can't be loaded in Safari on macOS (403 - Forbidden) #10464

gruselhaus · 2021-11-15T16:00:51Z

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2023356
https://issues.redhat.com/browse/OCPBUGSM-37199

Analysis / Root cause:

In Safari 15.x on macOS, the Devfiles samples can't be loaded from the backend. As viewed in the network inspector of the browser I can say that the app makes two calls to the backend. The first answer was a redirect, the second the failure. Unfortunately, the payload gets lost between the first and second call.

Solution Description:

I changed the http method from put to get and passed the registry via an url param instead of a payload since we are fetching data from the backend only.

Screen shots / Gifs for design review:

Before:

After:

Unit test coverage report:

Test setup:
Version-Release number of selected component (if applicable):
4.9

How reproducible:
Always

Steps to Reproduce:

Switch to dev console
Create a new project
Click on "+Add" or "View all samples"

Browser conformance:

Chrome
Firefox
Safari
Edge

gruselhaus · 2021-11-15T22:47:33Z

/test e2e-gcp-console

christoph-jerolimov · 2021-11-16T09:00:34Z

/ok-to-test
/retitle Bug 2023356: Devfiles can't be loaded in Safari on macOS (403 - Forbidden)

openshift-ci · 2021-11-16T09:00:39Z

@gruselhaus: This pull request references Bugzilla bug 2023356, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2023356: Devfiles can't be loaded in Safari on macOS (403 - Forbidden)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christoph-jerolimov · 2021-11-16T09:01:28Z

/bugzilla refresh

christoph-jerolimov · 2021-11-16T09:02:04Z

/assign

openshift-ci · 2021-11-16T09:03:36Z

@jerolimov: An error was encountered querying GitHub for users with public email (spathak@redhat.com) for bug 2023356 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christoph-jerolimov · 2021-11-16T09:05:34Z

/bugzilla refresh

openshift-ci · 2021-11-16T09:09:41Z

@jerolimov: An error was encountered querying GitHub for users with public email (spathak@redhat.com) for bug 2023356 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gruselhaus · 2021-11-16T10:56:40Z

/bugzilla refresh

openshift-ci · 2021-11-16T10:56:45Z

@gruselhaus: This pull request references Bugzilla bug 2023356, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gruselhaus · 2021-11-16T12:53:19Z

/retest

gruselhaus · 2021-11-16T13:40:35Z

/test frontend

christoph-jerolimov · 2021-11-16T18:36:00Z

pkg/server/server.go

 	gitopsEndpoint                   = "/api/gitops/"
 	devfileEndpoint                  = "/api/devfile/"
-	devfileSamplesEndpoint           = "/api/devfile/samples/"
+	devfileSamplesEndpoint           = "/api/devfile/samples"


This is actually the fix, but when I discussed this issue with @gruselhaus, we agreed that its not required to make a PUT call for fetching the devfile data. So the rest of the PR changes the PUT Api call to GET. 👍

christoph-jerolimov

Verified this PR with a cluster bot instance on Chrome, Firefox and Safari (all on macOS)

Works fine 👍

/approved
/lgtm
/retest

christoph-jerolimov · 2021-11-16T19:51:32Z

/cc @jhadvig @florkbr
Jakub or Bryan, can one of you please take look at the go changes? Thanks :)

openshift-bot · 2021-11-22T20:12:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-22T20:24:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-22T22:13:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

gruselhaus · 2021-11-22T22:42:42Z

@jerolimov the e2e-gcp-console still fails. Is there a way to bypass this test so Tide can merge this PR?

openshift-bot · 2021-11-23T01:39:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-23T02:15:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-23T02:27:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-23T03:03:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

karthikjeeyar · 2021-11-23T04:39:53Z

/retest

openshift-bot · 2021-11-23T06:25:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-23T06:59:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-23T08:11:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-23T09:39:22Z

@gruselhaus: An error was encountered querying GitHub for users with public email (spathak@redhat.com) for bug 2023356 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 2023356: Devfiles can't be loaded in Safari on macOS (403 - Forbidden)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gruselhaus · 2021-11-23T09:40:56Z

/bugzilla refresh

openshift-ci · 2021-11-23T09:41:00Z

@gruselhaus: This pull request references Bugzilla bug 2023356, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-11-23T10:16:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-23T17:12:18Z

@gruselhaus: All pull requests linked via external trackers have merged:

openshift/console#10464

Bugzilla bug 2023356 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2023356: Devfiles can't be loaded in Safari on macOS (403 - Forbidden)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gruselhaus · 2021-11-24T15:02:22Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2021-11-24T15:03:06Z

@gruselhaus: new pull request created: #10546

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Backport of openshift#10464 and openshift#10570

fix: devfiles are now fetched correctly

fdf00a5

openshift-ci bot requested review from andrewballantyne and jhadvig November 15, 2021 16:23

openshift-ci bot added component/backend Related to backend component/dev-console Related to dev-console labels Nov 15, 2021

openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 16, 2021

openshift-ci bot changed the title ~~Bug 2023356 - Devfiles can't be loaded in Safari on macOS (403 - Forbidden)~~ Bug 2023356: Devfiles can't be loaded in Safari on macOS (403 - Forbidden) Nov 16, 2021

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 16, 2021

openshift-ci bot assigned christoph-jerolimov Nov 16, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 16, 2021

openshift-ci bot requested a review from sanketpathak November 16, 2021 10:56

fixing tests

96263f2

christoph-jerolimov reviewed Nov 16, 2021

View reviewed changes

christoph-jerolimov approved these changes Nov 16, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021

openshift-merge-robot merged commit e901f09 into openshift:master Nov 23, 2021

gruselhaus deleted the fix-2023356 branch November 23, 2021 17:14

openshift-cherrypick-robot mentioned this pull request Nov 24, 2021

[release-4.9] Bug 2026400: Devfiles can't be loaded in Safari on macOS (403 - Forbidden) #10546

Closed

gruselhaus mentioned this pull request Nov 29, 2021

Bug 2027288: Devfile samples can't be loaded after fixing it on Safari (redirect caching issue) #10570

Merged

4 tasks

spadgett added this to the v4.10 milestone Dec 8, 2021

gruselhaus added a commit to yangcao77/console that referenced this pull request Dec 10, 2021

Backport of openshift#10464 and openshift#10570

2a5d458

gruselhaus mentioned this pull request Dec 11, 2021

Backport of #10464 and #10570 yangcao77/console#1

Merged

yangcao77 pushed a commit to yangcao77/console that referenced this pull request Dec 11, 2021

Merge pull request #1 from yangcao77/gruselhaus-4.9-backport

82e242f

Backport of openshift#10464 and openshift#10570

yangcao77 mentioned this pull request Dec 11, 2021

[release-4.9] Bug 2029861: backport the change from #10394 to release 4.9 #10620

Merged

meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025

Backport of openshift#10464 and openshift#10570

6155d41

meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025

Merge pull request #1 from yangcao77/gruselhaus-4.9-backport

3b4ca48

Backport of openshift#10464 and openshift#10570

Bug 2023356: Devfiles can't be loaded in Safari on macOS (403 - Forbidden) #10464

Bug 2023356: Devfiles can't be loaded in Safari on macOS (403 - Forbidden) #10464

Uh oh!

Conversation

gruselhaus commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Uh oh!

gruselhaus commented Nov 15, 2021

Uh oh!

christoph-jerolimov commented Nov 16, 2021

Uh oh!

openshift-ci bot commented Nov 16, 2021

Uh oh!

christoph-jerolimov commented Nov 16, 2021

Uh oh!

christoph-jerolimov commented Nov 16, 2021

Uh oh!

openshift-ci bot commented Nov 16, 2021

Uh oh!

christoph-jerolimov commented Nov 16, 2021

Uh oh!

openshift-ci bot commented Nov 16, 2021

Uh oh!

gruselhaus commented Nov 16, 2021

Uh oh!

openshift-ci bot commented Nov 16, 2021

Uh oh!

gruselhaus commented Nov 16, 2021

Uh oh!

gruselhaus commented Nov 16, 2021

Uh oh!

christoph-jerolimov Nov 16, 2021

Choose a reason for hiding this comment

Uh oh!

christoph-jerolimov left a comment

Choose a reason for hiding this comment

Uh oh!

christoph-jerolimov commented Nov 16, 2021

Uh oh!

openshift-bot commented Nov 22, 2021

Uh oh!

openshift-bot commented Nov 22, 2021

Uh oh!

openshift-bot commented Nov 22, 2021

Uh oh!

gruselhaus commented Nov 22, 2021

Uh oh!

openshift-bot commented Nov 23, 2021

Uh oh!

openshift-bot commented Nov 23, 2021

Uh oh!

openshift-bot commented Nov 23, 2021

Uh oh!

openshift-bot commented Nov 23, 2021

Uh oh!

karthikjeeyar commented Nov 23, 2021

Uh oh!

openshift-bot commented Nov 23, 2021

Uh oh!

openshift-bot commented Nov 23, 2021

Uh oh!

openshift-bot commented Nov 23, 2021

Uh oh!

openshift-ci bot commented Nov 23, 2021

Uh oh!

gruselhaus commented Nov 23, 2021

Uh oh!

openshift-ci bot commented Nov 23, 2021

Uh oh!

openshift-bot commented Nov 23, 2021

Uh oh!

openshift-ci bot commented Nov 23, 2021

Uh oh!

gruselhaus commented Nov 24, 2021

Uh oh!

openshift-cherrypick-robot commented Nov 24, 2021

Uh oh!

Reviewers

gruselhaus commented Nov 15, 2021 •

edited

Loading