[release-4.9] Bug 2029861: backport the change from #10394 to release 4.9 #10620

yangcao77 · 2021-12-06T20:57:26Z

Signed-off-by: Stephanie yangcao@redhat.com
This PR ports over change from #10394 to release 4.9 to fix https://bugzilla.redhat.com/show_bug.cgi?id=2025592
The current devfile handler for 4.9 does not work for devfile v2.2
According to the discussion on slack: https://coreos.slack.com/archives/C017YDKHQV6/p1637746963035100

Signed-off-by: Stephanie <yangcao@redhat.com>

openshift-ci · 2021-12-06T20:57:27Z

@yangcao77: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

backport the change from #10394 to release 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yangcao77 · 2021-12-06T21:00:11Z

/test ceph-storage-plugin
/test kubevirt-plugin

openshift-ci · 2021-12-06T21:00:15Z

@yangcao77: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test analyze
/test backend
/test ceph-storage-plugin
/test e2e-gcp-console
/test frontend
/test images
/test kubevirt-plugin

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-console-release-4.9-analyze
pull-ci-openshift-console-release-4.9-backend
pull-ci-openshift-console-release-4.9-e2e-gcp-console
pull-ci-openshift-console-release-4.9-frontend
pull-ci-openshift-console-release-4.9-images

Details

In response to this:

/test ci/prow/ceph-storage-plugin
/test ci/prow/kubevirt-plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2021-12-07T12:25:33Z

/retitle [release-4.9] Bug 2025592: backport the change from #10394 to release 4.9

openshift-ci · 2021-12-07T12:25:38Z

@yangcao77: This pull request references Bugzilla bug 2025592, which is invalid:

expected the bug to target the "4.9.z" release, but it targets "---" instead
expected Bugzilla bug 2025592 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.9] Bug 2025592: backport the change from #10394 to release 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rohitkrai03 · 2021-12-07T13:30:38Z

/bugzilla refresh

openshift-ci · 2021-12-07T13:30:45Z

@rohitkrai03: This pull request references Bugzilla bug 2025592, which is invalid:

expected Bugzilla bug 2025592 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rohitkrai03 · 2021-12-07T13:37:33Z

/retitle [release-4.9] Bug 2029861: backport the change from #10394 to release 4.9

openshift-ci · 2021-12-07T13:37:39Z

@yangcao77: This pull request references Bugzilla bug 2029861, which is invalid:

expected dependent Bugzilla bug 2025592 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.9] Bug 2029861: backport the change from #10394 to release 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2021-12-07T14:22:19Z

/bugzilla refresh

openshift-ci · 2021-12-07T14:22:28Z

@rottencandy: This pull request references Bugzilla bug 2029861, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2025592 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2025592 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2021-12-07T14:25:48Z

vendor/OWNERS

I think this file shouldn't be deleted.

my bad, this file got auto deleted. restored it

Signed-off-by: Stephanie <yangcao@redhat.com>

rottencandy

Tested on cluster-bot. Changes look good.

/cc @spadgett @invincibleJai

yangcao77 · 2021-12-07T16:52:23Z

/test e2e-gcp-console

gruselhaus · 2021-12-11T00:05:43Z

/retest-required

Backport of openshift#10464 and openshift#10570

yangcao77 · 2021-12-11T00:18:47Z

This PR also includes #10464 and #10570 for 4.9. contributed by @gruselhaus

gruselhaus · 2021-12-11T10:42:50Z

/assign

gruselhaus · 2021-12-11T10:42:56Z

/test e2e-gcp-console

gruselhaus · 2021-12-11T16:36:07Z

/retest-required

yangcao77 · 2021-12-14T19:31:22Z

@spadgett @invincibleJai @rottencandy
May I get a approve label and also a lgtm label for this PR?

rohitkrai03 · 2021-12-16T16:20:16Z

/assign @spadgett

rohitkrai03

/lgtm

spadgett

/approve

openshift-ci · 2022-01-04T13:30:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, rottencandy, spadgett, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rohitkrai03 · 2022-01-06T19:03:18Z

/label backport-risk-assessed

sanketpathak · 2022-01-21T17:48:32Z

Verified pr in cluster created using cluster-bot

/label cherry-pick-approved

openshift-ci · 2022-01-24T07:06:10Z

@yangcao77: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-24T07:06:37Z

@yangcao77: All pull requests linked via external trackers have merged:

openshift/console#10620

Bugzilla bug 2029861 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.9] Bug 2029861: backport the change from #10394 to release 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[release-4.9] Bug 2029861: backport the change from openshift#10394 to release 4.9

backport the change to 4.9

2792689

Signed-off-by: Stephanie <yangcao@redhat.com>

openshift-ci bot added the component/backend Related to backend label Dec 6, 2021

openshift-ci bot requested review from florkbr and jhadvig December 6, 2021 20:57

openshift-ci bot added component/dev-console Related to dev-console kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Dec 6, 2021

openshift-ci bot changed the title ~~backport the change from #10394 to release 4.9~~ [release-4.9] Bug 2025592: backport the change from #10394 to release 4.9 Dec 7, 2021

openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 7, 2021

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Dec 7, 2021

openshift-ci bot changed the title ~~[release-4.9] Bug 2025592: backport the change from #10394 to release 4.9~~ [release-4.9] Bug 2029861: backport the change from #10394 to release 4.9 Dec 7, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 7, 2021

openshift-ci bot requested a review from sanketpathak December 7, 2021 14:22

rottencandy reviewed Dec 7, 2021

View reviewed changes

fix gofmt error

cb5c6c9

Signed-off-by: Stephanie <yangcao@redhat.com>

yangcao77 force-pushed the release-4.9-cherrypick branch from 91f776a to cb5c6c9 Compare December 7, 2021 14:29

rottencandy approved these changes Dec 7, 2021

View reviewed changes

Backport of openshift#10464 and openshift#10570

2a5d458

gruselhaus mentioned this pull request Dec 11, 2021

Backport of #10464 and #10570 yangcao77/console#1

Merged

Merge pull request #1 from yangcao77/gruselhaus-4.9-backport

82e242f

Backport of openshift#10464 and openshift#10570

openshift-ci bot assigned gruselhaus Dec 11, 2021

elsony mentioned this pull request Dec 16, 2021

Move dev console to consume samples from devfile-samples org devfile/api#590

Closed

openshift-ci bot assigned spadgett Dec 16, 2021

rohitkrai03 approved these changes Dec 16, 2021

View reviewed changes

openshift-ci bot assigned rohitkrai03 Dec 16, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021

spadgett approved these changes Jan 4, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022

yangcao77 mentioned this pull request Jan 6, 2022

Devfiles in the OpenShift Dev Console samples are invalid devfile/api#666

Closed

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 6, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 21, 2022

openshift-merge-robot merged commit 30db239 into openshift:release-4.9 Jan 24, 2022

l0rd mentioned this pull request Jan 24, 2022

Check that workspaces start successfully with OCP 4.10 Console samples eclipse-che/che#21063

Closed

4 tasks

meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025

Merge pull request openshift#10620 from yangcao77/release-4.9-cherrypick

d5a4889

[release-4.9] Bug 2029861: backport the change from openshift#10394 to release 4.9

[release-4.9] Bug 2029861: backport the change from #10394 to release 4.9 #10620

[release-4.9] Bug 2029861: backport the change from #10394 to release 4.9 #10620

Uh oh!

Conversation

yangcao77 commented Dec 6, 2021

Uh oh!

openshift-ci bot commented Dec 6, 2021

Uh oh!

yangcao77 commented Dec 6, 2021

Uh oh!

openshift-ci bot commented Dec 6, 2021

Uh oh!

rottencandy commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

rohitkrai03 commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

rohitkrai03 commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

rottencandy commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

rottencandy Dec 7, 2021

Choose a reason for hiding this comment

Uh oh!

yangcao77 Dec 7, 2021

Choose a reason for hiding this comment

Uh oh!

rottencandy left a comment

Choose a reason for hiding this comment

Uh oh!

yangcao77 commented Dec 7, 2021

Uh oh!

gruselhaus commented Dec 11, 2021

Uh oh!

yangcao77 commented Dec 11, 2021

Uh oh!

gruselhaus commented Dec 11, 2021

Uh oh!

gruselhaus commented Dec 11, 2021

Uh oh!

gruselhaus commented Dec 11, 2021

Uh oh!

yangcao77 commented Dec 14, 2021

Uh oh!

rohitkrai03 commented Dec 16, 2021

Uh oh!

rohitkrai03 left a comment

Choose a reason for hiding this comment

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 4, 2022

Uh oh!

rohitkrai03 commented Jan 6, 2022

Uh oh!

sanketpathak commented Jan 21, 2022

Uh oh!

openshift-ci bot commented Jan 24, 2022

Uh oh!

openshift-ci bot commented Jan 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants