GitOps: Add error handling (#1278)

[keithchong]

See GitOps Jira 1278

Created PR for now, but #10420 should be merged first. Looks like only one file needs to be rebased, so I'll do this change after.

Signed-off-by: Keith Chong kykchong@redhat.com

[keithchong]

/retest

[keithchong]

Hi @debsmita1, @karthikjeeyar, while the tests are being looked at, could you review this? We'd like to get this completed for this sprint.

[keithchong]

Hi @vikram-raj could you please review this as well?

[keithchong]

/retest

[keithchong]

Hi @Preeticp, this is a bug fix to better handle error conditions. Do we typically add documentation to these types of fixes? If not, the I think we can add the label for approving docs.

[keithchong]

@RickJWagner , I think we need the px-approved label on this one.

[divyanshiGupta]

@keithchong It seems you havent pushed the changes.

[keithchong]

Hi @divyanshiGupta , indeed. It's pushed now.

[divyanshiGupta]

@keithchong you need to resolve the conflicts.

[keithchong]

Yeah, thanks @divyanshiGupta , it's because PR 10500 was merged. I also get the feeling I need to rebase again once 10420 is merged, which should be done first.

[keithchong]

/retest

[RickJWagner]

/label px-approved

[divyanshiGupta]

/retest

[divyanshiGupta]

/lgtm

[keithchong]

Hi @varshab1210 , as QE rep, could you please approve this?

[varshab1210]

/label qe-approved

[openshift-ci]

@keithchong: The label(s) /label approved cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

Details

In response to this:

/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rohitkrai03]

/approve

[keithchong]

Hi @divyanshiGupta , could you please re-add the lgtm label. I had to rebase because another PR was just merged.

[andrewballantyne]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, divyanshiGupta, keithchong, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/packages/gitops-plugin/OWNERS [andrewballantyne,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@keithchong: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.