Bug 2071719: remove .pf-c-button.pf-m-link override

[rhamilto]

This rule was added in #2666 in order to allow the pencil icon to wrap independently of the text prior to patternfly/patternfly#3470. Now that the issue has been addressed upstream, this override is no longer needed.

Note this change could impact other instances where isInline/.pf-m-inline is not in use on link buttons, but after searching through the code, I don't see any such instances where the change should pose an issue, but could have overlooked one or more.

[openshift-ci]

@rhamilto: This pull request references Bugzilla bug 2071719, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2071719: remove .pf-c-button.pf-m-link override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@rhamilto: This pull request references Bugzilla bug 2071719, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2071719: remove .pf-c-button.pf-m-link override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/bugzilla refresh

[openshift-ci]

@rhamilto: This pull request references Bugzilla bug 2071719, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@rhamilto: This pull request references Bugzilla bug 2071719, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

Bug 2071719: remove .pf-c-button.pf-m-link override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@rhamilto: This pull request references Bugzilla bug 2071719, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

Bug 2071719: remove .pf-c-button.pf-m-link override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sg00dwin]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/public/style/OWNERS [rhamilto,sg00dwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@rhamilto: All pull requests linked via external trackers have merged:

• openshift/console#11306

Bugzilla bug 2071719 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2071719: remove .pf-c-button.pf-m-link override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

@rhamilto Do you know if the version of PF in 4.10 has the upstream fix? This is impacting the ACM plugin, so would be good to disable in 4.10.z as well.

cc @jamestalton

[rhamilto]

@rhamilto Do you know if the version of PF in 4.10 has the upstream fix? This is impacting the ACM plugin, so would be good to disable in 4.10.z as well.

It does at the upstream fix merged on Sep 10, 2020.

[spadgett]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@spadgett: new pull request created: #11315

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/bugzilla refresh

[openshift-ci]

@rhamilto: Bugzilla bug 2071719 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.