Skip to content

Effort to convert inline edit button links with pencil icon to use pf4 components #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 27, 2019
Merged

Effort to convert inline edit button links with pencil icon to use pf4 components #2666

openshift-merge-robot merged 1 commit into from
Sep 27, 2019

Conversation

@sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Sep 10, 2019 •
edited
Loading

Screen Shot 2019-09-10 at 3 52 04 PM

Screen Shot 2019-09-10 at 3 52 36 PM

note: related changes to kubevirt-plugin vm pages will be in a separate pr

@sg00dwin sg00dwin requested a review from rhamilto September 10, 2019 20:02
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality component/olm Related to OLM labels Sep 10, 2019
@spadgett
Copy link
Member

spadgett commented Sep 10, 2019

/hold
for 4.3

/assign @rhamilto

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2019
@spadgett spadgett added this to the v4.3 milestone Sep 10, 2019
@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch 2 times, most recently from e23e35a to 9698dff Compare September 10, 2019 20:34
rhamilto
rhamilto reviewed Sep 10, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.co-modal-btn-link* styles should be removed, no?

@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch from 9698dff to fd12a0b Compare September 10, 2019 21:25
@rhamilto
Copy link
Member

rhamilto commented Sep 11, 2019

@sg00dwin, you've got linting errors.

@sg00dwin
Copy link
Member Author

sg00dwin commented Sep 11, 2019

.co-modal-btn-link* styles should be removed, no?

It's still being used in a couple pages within kubevirt-plugin. I'll be opening a separate PR removing those instances and will remove then.

@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch 3 times, most recently from d09262c to 0fdfae3 Compare September 12, 2019 16:11
@sg00dwin
Copy link
Member Author

sg00dwin commented Sep 12, 2019

/retest

@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch 4 times, most recently from 9b0433b to 4f199fa Compare September 13, 2019 15:44
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2019
@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch from 4f199fa to 8232065 Compare September 13, 2019 18:29
@spadgett spadgett force-pushed the modal-btn-link-updates branch from 8232065 to c9aa4e0 Compare September 13, 2019 19:04
@spadgett
Copy link
Member

spadgett commented Sep 13, 2019

/retest

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2019
@spadgett
Copy link
Member

spadgett commented Sep 26, 2019 •
edited
Loading

@sg00dwin you need to run prettier on frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx to fix the lint errors

@spadgett
Copy link
Member

spadgett commented Sep 26, 2019

/lgtm cancel
to avoid retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch from 9cbe7c9 to 652ccd8 Compare September 26, 2019 14:56
@rhamilto
Copy link
Member

rhamilto commented Sep 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@rhamilto
Copy link
Member

rhamilto commented Sep 26, 2019

/retest

@rhamilto
Copy link
Member

rhamilto commented Sep 26, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch from 652ccd8 to e7fc8ab Compare September 26, 2019 21:03
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
rhamilto
rhamilto reviewed Sep 27, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch from e7fc8ab to 372a7d7 Compare September 27, 2019 14:54
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@rhamilto
Copy link
Member

rhamilto commented Sep 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@sg00dwin sg00dwin force-pushed the modal-btn-link-updates branch from 372a7d7 to 88f71d9 Compare September 27, 2019 15:54
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@sg00dwin
Copy link
Member Author

sg00dwin commented Sep 27, 2019

/retest

@rhamilto
Copy link
Member

rhamilto commented Sep 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ccd4c94 into openshift:master Sep 27, 2019
@sg00dwin sg00dwin deleted the modal-btn-link-updates branch October 1, 2019 18:50
@spadgett spadgett mentioned this pull request Oct 2, 2019
Merged
@rhamilto rhamilto mentioned this pull request Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@josephschorr josephschorr Awaiting requested review from josephschorr

Assignees

@rhamilto rhamilto

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@sg00dwin @spadgett @rhamilto @openshift-ci-robot @openshift-merge-robot