Skip to content

Refresh metrics when changing selected overview project #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 26, 2019
Merged

Refresh metrics when changing selected overview project #1141

openshift-merge-robot merged 1 commit into from
Jan 26, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jan 25, 2019

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2019
@spadgett spadgett force-pushed the overview-metrics-ns-change branch from 25daec0 to 0b5c574 Compare January 25, 2019 20:03
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2019
spadgett
spadgett commented Jan 25, 2019
View reviewed changes
frontend/public/components/overview/index.tsx
}

fetchMetrics(): void {
fetchMetrics = (): void => {
Copy link
Member Author

@spadgett spadgett Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using fat arrow to bind to this since we pass this.fetchMetrics directly to setTimeout below

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
TheRealJon
TheRealJon approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Jan 25, 2019

Deploy image flake

/retest

1) Deploy Image Deploy Image page : can be used to create an app based on an image
   Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

@spadgett
Copy link
Member Author

spadgett commented Jan 26, 2019

Install failed

/retest

@spadgett
Copy link
Member Author

spadgett commented Jan 26, 2019

/retest

3 similar comments
@spadgett
Copy link
Member Author

spadgett commented Jan 26, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Jan 26, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Jan 26, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit d86dcf4 into openshift:master Jan 26, 2019
@spadgett spadgett deleted the overview-metrics-ns-change branch January 26, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

Assignees

@TheRealJon TheRealJon

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spadgett @TheRealJon @openshift-ci-robot @openshift-merge-robot