Skip to content

Refresh metrics when changing selected overview project #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jan 26, 2019
Merged

Refresh metrics when changing selected overview project #1141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions frontend/public/components/overview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ class OverviewMainContent_ extends React.Component<OverviewMainContentProps, Ove
} = this.props;
const {filterValue, selectedGroup} = this.state;

if (!_.isEqual(namespace, prevProps.namespace)
if (namespace !== prevProps.namespace
|| loaded !== prevProps.loaded
|| !_.isEqual(buildConfigs, prevProps.buildConfigs)
|| !_.isEqual(builds, prevProps.builds)
Expand Down Expand Up @@ -495,9 +495,15 @@ class OverviewMainContent_ extends React.Component<OverviewMainContentProps, Ove
// OverviewHeading doesn't keep the value in state.
this.setState({ filterValue: '' });
}

// Fetch new metrics when the namespace changes.
if (namespace !== prevProps.namespace) {
clearInterval(this.metricsInterval);
this.fetchMetrics();
}
}

fetchMetrics(): void {
fetchMetrics = (): void => {
Copy link
Member Author

@spadgett spadgett Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using fat arrow to bind to this since we pass this.fetchMetrics directly to setTimeout below

if (!prometheusBasePath) {
// Component is not mounted or proxy has not been set up.
return;
Expand Down