Skip to content

feat: Add Deployment History Tab (#1950) #11439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 11, 2022
Merged

feat: Add Deployment History Tab (#1950) #11439

openshift-merge-robot merged 1 commit into from
May 11, 2022

Conversation

@keithchong
Copy link
Contributor

@keithchong keithchong commented May 4, 2022 •
edited
Loading

This PR is to add the Deployment History to the details page of an application. See GitOps Story 1950 for screenshots, videos, and details. This also includes the changes for 1891, to move the Details Overview page to an Overview tab.

Signed-off-by: Keith Chong kykchong@redhat.com

HistoryTab

@openshift-ci openshift-ci bot added component/gitops Related to gitops-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 4, 2022
@keithchong keithchong force-pushed the 1950-DeploymentHistory branch from 1086ab1 to 38f343f Compare May 5, 2022 17:44
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2022
@keithchong keithchong force-pushed the 1950-DeploymentHistory branch from 38f343f to 0707e03 Compare May 5, 2022 18:37
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2022
@keithchong keithchong force-pushed the 1950-DeploymentHistory branch from 0707e03 to f052db9 Compare May 5, 2022 18:51
@keithchong
Copy link
Contributor Author

keithchong commented May 6, 2022 •
edited
Loading

Hi @vikram-raj , could you please review and approve this? We want to get this in for 4.11. Thanks.

@keithchong
Copy link
Contributor Author

keithchong commented May 7, 2022

/retest

vikram-raj
vikram-raj reviewed May 9, 2022
View reviewed changes
@keithchong keithchong force-pushed the 1950-DeploymentHistory branch from 32b4195 to cc21c11 Compare May 9, 2022 17:38
vikram-raj
vikram-raj reviewed May 10, 2022
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keithchong, I verified it, and works as expected.

can you please squash the commits

@keithchong
feat: Add Deployment History Tab (openshift#1950)
c25aef1 
Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong force-pushed the 1950-DeploymentHistory branch from cc21c11 to c25aef1 Compare May 10, 2022 14:49
vikram-raj
vikram-raj reviewed May 10, 2022
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

@keithchong: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vikram-raj
vikram-raj reviewed May 11, 2022
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 11, 2022
@keithchong
Copy link
Contributor Author

keithchong commented May 11, 2022 •
edited
Loading

Hi @RickJWagner , could you please add the px-approved label for this?
Hi @Preeticp , could you please add the docs-approved label?

Edit: please disregard the above. I've added the labels

The epic https://issues.redhat.com/browse/GITOPS-1269 has the doc-ack and px-ack labels and we have a story to update the docs in kam.

@keithchong
Copy link
Contributor Author

keithchong commented May 11, 2022

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels May 11, 2022
christoph-jerolimov
christoph-jerolimov approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, keithchong, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@RickJWagner
Copy link

RickJWagner commented May 11, 2022

/label px-approved

@openshift-merge-robot openshift-merge-robot merged commit 52a6599 into openshift:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

2 more reviewers

@vikram-raj vikram-raj vikram-raj requested changes

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vikram-raj vikram-raj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/gitops Related to gitops-plugin docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@keithchong @RickJWagner @christoph-jerolimov @vikram-raj @openshift-merge-robot