Skip to content

Conversation

@cloudbehl
Copy link
Contributor

@cloudbehl cloudbehl commented Jul 8, 2019

Based on these PR: #1884 #1803
Screenshot from 2019-07-08 17-39-20

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2019
@cloudbehl cloudbehl changed the title Alert health details card Added alerts for ceph-storage-tab Jul 8, 2019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key can be just index

<AlertItem key={index} alert={alert} />

@spadgett spadgett added this to the v4.2 milestone Jul 8, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2019
@cloudbehl cloudbehl force-pushed the alert-health-details-card branch from 8b3c67e to bbe5cf2 Compare July 9, 2019 22:17
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2019
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
@cloudbehl cloudbehl force-pushed the alert-health-details-card branch from bbe5cf2 to 4f90bee Compare July 9, 2019 22:21
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2019
@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cloudbehl, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5276c36 into openshift:master Jul 10, 2019
keithchong added a commit to keithchong/console that referenced this pull request May 5, 2022
Signed-off-by: Keith Chong <kykchong@redhat.com>
reginaelyse pushed a commit to reginaelyse/console that referenced this pull request May 5, 2022
Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong added a commit to keithchong/console that referenced this pull request May 10, 2022
Signed-off-by: Keith Chong <kykchong@redhat.com>
openshift-merge-robot added a commit that referenced this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants