Add alerts card #1884

pcbailey · 2019-07-02T10:41:01Z

This PR adds the alerts card to the dashboard overview page. The alerts card does not display if alert-manager is not available.

Loaded alerts card:

Alerts card in loading state:

@rawagner

openshift-ci-robot · 2019-07-02T10:41:15Z

Hi @pcbailey. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frontend/public/components/dashboard/alerts-card/alert-item.tsx

frontend/public/components/dashboard/alerts-card/alerts-card.scss

frontend/public/components/dashboard/alerts-card/utils.tsx

frontend/public/components/dashboards-page/overview-dashboard/alerts-card.tsx

frontend/public/actions/dashboards.ts

frontend/public/components/dashboard/alerts-card/alerts-card.scss

frontend/public/components/dashboard/health-card/health-card.scss

frontend/public/components/dashboards-page/overview-dashboard/health-card.tsx

spadgett · 2019-07-03T19:01:26Z

/approve
/assign @rawagner

rawagner · 2019-07-04T11:05:31Z

/ok-to-test

frontend/public/components/dashboards-page/with-dashboard-resources.tsx

rawagner · 2019-07-08T14:04:02Z

/lgtm

openshift-bot · 2019-07-08T19:05:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

frontend/public/components/dashboards-page/overview-dashboard/health-card.tsx

cloudbehl · 2019-07-08T19:10:18Z

frontend/public/components/dashboards-page/overview-dashboard/health-card.tsx

can we move this to common place so other component leverage this? @rawagner @pcbailey

Suggested change

const getAlerts = (alertsResults: any): Alert[] => {

const getAlerts = (alertsResults: any): Alert[] => {

const alertsResponse = alertsResults ? alertsResults.getIn([ALERTS_KEY, 'result'], []) : [];

return Array.isArray(alertsResponse) ? alertsResponse : [];

};

@cloudbehl Do you have any suggestions on a good location for it?

i'd suggest dashboard/health-card/utils.ts

I thought about that, but I wasn't sure if that was "common" enough.

I have moved it to dashboard/health-card/utils.ts.

rawagner · 2019-07-09T11:06:38Z

frontend/public/components/dashboard/health-card/health-card.scss

please alphabetize these classes/rules

rawagner · 2019-07-09T11:07:22Z

frontend/public/components/dashboards-page/overview-dashboard/health-card.tsx

rawagner · 2019-07-09T11:08:23Z

frontend/public/components/dashboards-page/with-dashboard-resources.tsx

can you alphabetize these too ?

rawagner · 2019-07-09T11:29:36Z

/lgtm

openshift-ci-robot · 2019-07-09T11:29:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-07-09T12:51:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-09T13:43:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-07-09T20:56:22Z

@pcbailey: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/frontend	`4945e6b`	link	`/test frontend`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2019

openshift-ci-robot requested review from jcaianirh and jeff-phillips-18 July 2, 2019 10:41

pcbailey force-pushed the add-alerts-dashboard-card branch from 9dc8889 to accb171 Compare July 2, 2019 12:11

rawagner suggested changes Jul 2, 2019

View reviewed changes

spadgett added this to the v4.2 milestone Jul 2, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2019

pcbailey force-pushed the add-alerts-dashboard-card branch from accb171 to eb5fcb9 Compare July 3, 2019 12:27

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2019

pcbailey force-pushed the add-alerts-dashboard-card branch from eb5fcb9 to a21cfd6 Compare July 3, 2019 12:47

spadgett reviewed Jul 3, 2019

View reviewed changes

frontend/public/components/dashboard/health-card/health-card.scss Outdated Show resolved Hide resolved

frontend/public/components/dashboards-page/overview-dashboard/health-card.tsx Outdated Show resolved Hide resolved

openshift-ci-robot assigned rawagner Jul 3, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 4, 2019

cloudbehl mentioned this pull request Jul 8, 2019

Added alerts for ceph-storage-tab #1950

Merged

rawagner suggested changes Jul 8, 2019

View reviewed changes

frontend/public/components/dashboards-page/with-dashboard-resources.tsx Outdated Show resolved Hide resolved

frontend/public/components/dashboards-page/with-dashboard-resources.tsx Outdated Show resolved Hide resolved

pcbailey force-pushed the add-alerts-dashboard-card branch 2 times, most recently from d9084de to 3154dbe Compare July 8, 2019 13:33

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019

cloudbehl reviewed Jul 8, 2019

View reviewed changes

pcbailey force-pushed the add-alerts-dashboard-card branch from 3154dbe to 5eab673 Compare July 8, 2019 19:43

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2019

openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 8, 2019

pcbailey force-pushed the add-alerts-dashboard-card branch from 5eab673 to 3c83668 Compare July 9, 2019 10:30

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 9, 2019

rawagner suggested changes Jul 9, 2019

View reviewed changes

Add alerts dashboard card

4945e6b

pcbailey force-pushed the add-alerts-dashboard-card branch from 3c83668 to 4945e6b Compare July 9, 2019 11:27

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019

openshift-merge-robot merged commit 25cf470 into openshift:master Jul 9, 2019

pcbailey deleted the add-alerts-dashboard-card branch October 26, 2022 12:30

-const getAlerts = (alertsResults: any): Alert[] => {
+const getAlerts = (alertsResults: any): Alert[] => {
+const alertsResponse = alertsResults ? alertsResults.getIn([ALERTS_KEY, 'result'], []) : [];
+  return Array.isArray(alertsResponse) ? alertsResponse : [];
+};

Add alerts card #1884

Add alerts card #1884

Uh oh!

Conversation

pcbailey commented Jul 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spadgett commented Jul 3, 2019

Uh oh!

rawagner commented Jul 4, 2019

Uh oh!

Uh oh!

Uh oh!

rawagner commented Jul 8, 2019

Uh oh!

openshift-bot commented Jul 8, 2019

Uh oh!

Uh oh!

cloudbehl Jul 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pcbailey Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

rawagner Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

pcbailey Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

pcbailey Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

rawagner Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

rawagner Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

rawagner Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

rawagner commented Jul 9, 2019

Uh oh!

openshift-ci-robot commented Jul 9, 2019

Uh oh!

openshift-bot commented Jul 9, 2019

Uh oh!

openshift-bot commented Jul 9, 2019

Uh oh!

openshift-ci-robot commented Jul 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pcbailey commented Jul 2, 2019 •

edited

Loading

cloudbehl Jul 8, 2019 •

edited

Loading