Skip to content

devconsole: setup sub-dir with OWNERS file #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 14, 2019
Merged

devconsole: setup sub-dir with OWNERS file #1180

openshift-merge-robot merged 2 commits into from
Mar 14, 2019

Conversation

@christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Feb 11, 2019

Establishing the extend/devconsole space in the repository to contain all developer perspective related work according to phase 1 of the Console Extensibility Plan

Including an OWNERS file with team members as reviewers and approvers.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2019

Hi @christianvogt. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joshuawilson
Copy link
Contributor

joshuawilson commented Feb 12, 2019

You might want to add Nimisha too.

@jhadvig
Copy link
Member

jhadvig commented Feb 12, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2019
@christianvogt
Copy link
Contributor Author

christianvogt commented Feb 13, 2019

/test console-e2e

@kwk
Copy link

kwk commented Feb 14, 2019

/retest

@kwk
Copy link

kwk commented Feb 14, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2019

@kwk: changing LGTM is restricted to assignees, and only openshift/console repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kwk
kwk reviewed Feb 14, 2019
View reviewed changes
Copy link

@kwk kwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

According to this file format specification: https://go.k8s.io/owners

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2019

@kwk: changing LGTM is restricted to assignees, and only openshift/console repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

According to this file format specification: https://go.k8s.io/owners

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joshuawilson
Copy link
Contributor

joshuawilson commented Feb 15, 2019

/test console-e2e

@joshuawilson
Copy link
Contributor

joshuawilson commented Feb 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

/retest

@joshuawilson
Copy link
Contributor

joshuawilson commented Mar 8, 2019

@spadgett any idea why this keeps failing? It just adds 2 new files and the directory for them.

@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

e2e tests are failing because you don't have #1255 in master-next. An OperatorHub change broke the console-e2e tests.

I'll retarget to master

@spadgett spadgett changed the base branch from master-next to master March 8, 2019 20:44
@spadgett
Copy link
Member

spadgett commented Mar 12, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 13, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, joshuawilson, kwk, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Mar 13, 2019

We're investigating the OperatorHub flakes now

/retest

@spadgett
Copy link
Member

spadgett commented Mar 13, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c36caed into openshift:master Mar 14, 2019
@christianvogt christianvogt deleted the devconsole-owners branch May 9, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kwk kwk kwk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joshuawilson joshuawilson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@christianvogt @openshift-ci-robot @joshuawilson @jhadvig @kwk @spadgett @openshift-bot @openshift-merge-robot