Bandaid fix OperatorHub tests for etcd operator #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
requested review from
dtaylor113,
gallettilance,
jeff-phillips-18 and
spadgett
openshift-ci-robot
added
the
size/S
Contributor
|
/retest |
gallettilance
approved these changes
Mar 6, 2019
Contributor
|
@spadgett I think this is why all the tests were failing. Thanks @SamiSousa for catching this! |
Contributor
|
/retest |
Member
|
/retest |
2 similar comments
Author
|
/retest |
Author
|
/retest |
Author
|
Member
|
/retest |
SamiSousa
force-pushed
the
operator-hub-tests
branch
from
7585dfc to
5d2885d
Compare
openshift-ci-robot
added
lgtm
Member
|
@SamiSousa OperatorHub tests failed :( |
Member
|
/retest |
Author
|
@spadgett The OperatorHub and OLM test suites passed for me when I created the PR this morning, launching a new cluster to double check now. |
- Changed OperatorHub test to check for OwnNamespace installmode rather than AllNamespaces - Updated namespace to match testName for single namespace install - Added views for selecting namespace on Subscription page The etcd operator in community-operators changed late last week, replacing AllNamespaces functionality with SingleNamespace. This puts a bandaid on the issue. Operators in community-operators can change frequently, and because of this OperatorHub tests will be unstable when relying on external content.
SamiSousa
force-pushed
the
operator-hub-tests
branch
from
5d2885d to
0805b1e
Compare
Author
|
Updated tests to use |
spadgett
approved these changes
Mar 6, 2019
| export const createSubscriptionFormBtn = element(by.buttonText('Subscribe')); | ||
| export const createSubscriptionFormInstallMode = element(by.cssContainingText('label', 'Installation Mode')); | ||
|
|
||
| export const installNamespaceDropdown = $('.dropdown--full-width'); |
Member
There was a problem hiding this comment.
We might give this a more descriptive ID than we're currently using in the form, and then we can select the right dropdown by ID here.
Don't worry about this if the PR passes tests, though. We need to unblock the queue.
Member
|
Tests are green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than AllNamespaces
The etcd operator in community-operators changed late last week,
replacing AllNamespaces functionality with SingleNamespace.
This puts a bandaid on the issue.
Operators in community-operators can change frequently, and
because of this OperatorHub tests will be unstable when relying on
external content.
/cc @galletti94 @jeff-phillips-18 @spadgett @dtaylor113
This will help tests pass for now, but it's not a long-term solution. I suggest we either use a separate quay namespace with stable operator bundles and add that as a "Custom" OperatorSource during this test, or possibly figure out installmodes on the fly.