Skip to content

Change Operator Hub to OperatorHub #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 11, 2019
Merged

Change Operator Hub to OperatorHub #1192

openshift-merge-robot merged 1 commit into from
Mar 11, 2019

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Feb 15, 2019

Fixes https://jira.coreos.com/browse/CONSOLE-1280
Change all instances of "Operator Hub' in the UI to "OperatorHub"

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Feb 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm Indicates that a PR is ready to be merged. labels Feb 15, 2019
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 15, 2019

/retest

2 similar comments
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 15, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 15, 2019

/retest

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Feb 15, 2019

Same error as the other PRs, think the authentication-operator PR 73 will also unclog this one.

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Feb 16, 2019

/retest

operator PR 143 merged, lets see if the TLS issue with the authentication operator goes away.

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Feb 16, 2019

/retest

1 similar comment
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 18, 2019

/retest

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Feb 18, 2019

/retest

artifacts are gone, need to generate some new fail data.

@spadgett
Copy link
Member

spadgett commented Feb 22, 2019

/retest

1 similar comment
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 22, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 22, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
@spadgett
Copy link
Member

spadgett commented Feb 22, 2019

@TheRealJon merge conflict :/

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2019
@spadgett
Copy link
Member

spadgett commented Feb 24, 2019

/hold cancel
but will need rebase

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2019
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 25, 2019
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 25, 2019

Rebased, needs lgtm again

spadgett
spadgett approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@spadgett
Copy link
Member

spadgett commented Feb 25, 2019

flake https://jira.coreos.com/browse/CONSOLE-1294

/retest

@spadgett
Copy link
Member

spadgett commented Feb 26, 2019

/retest

4 similar comments
@spadgett
Copy link
Member

spadgett commented Feb 26, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 26, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 27, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 27, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 27, 2019

performance test flake

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 27, 2019

/retest

3 similar comments
@spadgett
Copy link
Member

spadgett commented Feb 27, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 27, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

performance test flake

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

level=error msg="\t* aws_instance.master.2: Error launching source instance: timeout while waiting for state to become 'success' (timeout: 30s)"

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019 

level=error msg="\t* module.vpc.aws_route.to_nat_gw[4]: 1 error occurred:"
level=error msg="\t* aws_route.to_nat_gw.4: Error creating route: timeout while waiting for state to become 'success' (timeout: 2m0s)"

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

/retest

4 similar comments
@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 28, 2019

/retest

spadgett
spadgett requested changes Mar 1, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update performance tests for the new nav item title.

@spadgett
Copy link
Member

spadgett commented Mar 1, 2019

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2019
@SamiSousa SamiSousa mentioned this pull request Mar 6, 2019
Merged
@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 11, 2019

@spadgett Rebased and fixed performance test

@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4aefc9e into openshift:master Mar 11, 2019
@TheRealJon TheRealJon deleted the CONSOLE-1280 branch March 12, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett requested changes

+1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

@spadgett spadgett

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TheRealJon @benjaminapetersen @spadgett @openshift-ci-robot @openshift-merge-robot