Fix config singleton names #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
Contributor
Author
|
@ericavonb @enj fyi |
Contributor
Author
Contributor
Author
|
In reference to openshift/cluster-authentication-operator#73 This is the correct fix, the authentication-operator shouldn't need an update. |
Contributor
|
/lgtm You will need to use distinct tweak list options for your informers if you decide to use a no-op one for these resources. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, enj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold Testing |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
Author
|
/retest on the |
This was referenced Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global config & operator config should be named
cluster, notconsole.console.config.openshift.io - cluster
console.operator.openshift.io - cluster
(Note ClusterOperator is still named
console).