Enable tab into Create button #1372

nicolethoen · 2019-04-02T15:33:19Z

Fixes CONSOLE-1156

spadgett

/lgtm

openshift-bot · 2019-04-02T15:38:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-04-02T15:52:21Z

Operator Hub tests are currently broken in CI. Skipping.

/skip

bmignano

LGTM! Thanks @nicolethoen !

openshift-ci-robot · 2019-04-02T16:01:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmignano, nicolethoen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spadgett · 2019-04-02T19:19:58Z

console e2e failures fixed by #1375

spadgett · 2019-04-02T19:20:34Z

/skip

spadgett · 2019-04-03T17:13:44Z

/retest

spadgett · 2019-04-03T20:22:47Z

/retest

openshift-bot · 2019-04-03T22:03:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-03T22:59:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T04:38:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T05:42:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T07:27:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T08:18:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T08:49:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jhadvig · 2019-04-04T09:20:32Z

WebDriverError: chrome not reachable
  (Session info: headless chrome=67.0.3396.62)
  (Driver info: chromedriver=2.38.552522 (437e6fbedfa8762dec75e2c5b3ddb86763dc9dcb),platform=Linux 3.10.0-957.1.3.el7.x86_64 x86_64)
    at Object.checkLegacyResponse (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/error.js:546:15)
    at parseHttpResponse (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/http.js:509:13)
    at doSend.then.response (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/http.js:441:30)
    at process._tickCallback (internal/process/next_tick.js:68:7)

/retest

jhadvig · 2019-04-04T10:18:23Z

/retest

openshift-bot · 2019-04-04T11:33:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T12:12:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T12:25:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-04-04T12:49:42Z

/skip

spadgett · 2019-04-04T12:51:43Z

This failure is related to the other test errors. Operator Hub seems to crash Chrome in CI :(

cc @jeff-phillips-18 @alecmerdler

Performance test downloads new bundle for operator-hub 3.53s

go run hack/e2e.go -v -test --test_args='--ginkgo.focus=Performance\stest\sdownloads\snew\sbundle\sfor\soperator\-hub$'

WebDriverError: unknown error: session deleted because of page crash
from unknown error: cannot determine loading status
from tab crashed

spadgett · 2019-04-04T13:13:59Z

/test e2e-aws-console

openshift-bot · 2019-04-04T15:08:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T16:27:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T16:54:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T17:38:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T17:45:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T17:58:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T19:03:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T20:08:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T21:00:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-04T23:36:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T00:28:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T03:57:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T05:53:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T07:13:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T08:05:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T09:10:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T12:12:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T14:09:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T17:24:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-05T19:34:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-04-05T20:36:05Z

@nicolethoen: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-console-olm	`c2b1222`	link	`/test e2e-aws-console-olm`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2019-04-06T00:45:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Enable tab into Create button

c2b1222

nicolethoen requested review from bmignano and spadgett April 2, 2019 15:33

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2019

openshift-ci-robot requested review from jcaianirh and kyoto April 2, 2019 15:33

spadgett approved these changes Apr 2, 2019

View reviewed changes

openshift-ci-robot assigned spadgett Apr 2, 2019

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2019

bmignano approved these changes Apr 2, 2019

View reviewed changes

spadgett added this to the v4.1 milestone Apr 2, 2019

openshift-merge-robot merged commit 24654a4 into openshift:master Apr 6, 2019

Enable tab into Create button #1372

Enable tab into Create button #1372

Uh oh!

Conversation

nicolethoen commented Apr 2, 2019

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Apr 2, 2019

Uh oh!

spadgett commented Apr 2, 2019

Uh oh!

bmignano left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 2, 2019

Uh oh!

spadgett commented Apr 2, 2019

Uh oh!

spadgett commented Apr 2, 2019

Uh oh!

spadgett commented Apr 3, 2019

Uh oh!

spadgett commented Apr 3, 2019

Uh oh!

openshift-bot commented Apr 3, 2019

Uh oh!

openshift-bot commented Apr 3, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

jhadvig commented Apr 4, 2019

Uh oh!

jhadvig commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

spadgett commented Apr 4, 2019

Uh oh!

spadgett commented Apr 4, 2019

Uh oh!

spadgett commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 4, 2019

Uh oh!

openshift-bot commented Apr 5, 2019

Uh oh!

openshift-bot commented Apr 5, 2019

Uh oh!

openshift-ci-robot commented Apr 5, 2019 •

edited

Loading