Skip to content

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 2, 2019

This should fix the errors we're seeing in CI post rebase.

/assign @rhamilto

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2019
@rhamilto
Copy link
Member

rhamilto commented Apr 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

/skip

@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

/retest

4 similar comments
@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Apr 3, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit c34a435 into openshift:master Apr 3, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 86035f4 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett mentioned this pull request Apr 7, 2019
2 tasks
@spadgett spadgett deleted the deploy-image-default-env branch June 1, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants