Skip to content

Show "Evicted" instead of "Failed" for evicted pod status #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 3, 2019
Merged

Show "Evicted" instead of "Failed" for evicted pod status #1373

openshift-merge-robot merged 1 commit into from
Apr 3, 2019

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Apr 2, 2019

@TheRealJon TheRealJon requested a review from spadgett April 2, 2019 15:38
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2019
spadgett
spadgett approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

spadgett commented Apr 2, 2019

/cherrypick release-3.11

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 2, 2019

@spadgett: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2019
@spadgett
Copy link
Member

spadgett commented Apr 2, 2019

Operator Hub tests are currently broken in CI. Skipping.

/skip

@spadgett
Copy link
Member

spadgett commented Apr 2, 2019

/retest

1 similar comment
@spadgett
Copy link
Member

spadgett commented Apr 2, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Apr 2, 2019

/retest
/skip

@spadgett
Copy link
Member

spadgett commented Apr 2, 2019

console e2e failures fixed by #1375

@spadgett
Copy link
Member

spadgett commented Apr 3, 2019

/retest

1 similar comment
@spadgett
Copy link
Member

spadgett commented Apr 3, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2019 •
edited
Loading

@TheRealJon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 931cd92 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member

spadgett commented Apr 3, 2019

/skip

@openshift-merge-robot openshift-merge-robot merged commit 87cf25b into openshift:master Apr 3, 2019
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 3, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 3, 2019

@spadgett: new pull request created: #1379

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon TheRealJon deleted the bug-1694788 branch June 26, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TheRealJon @spadgett @openshift-cherrypick-robot @openshift-ci-robot @openshift-bot @openshift-merge-robot