Skip to content

Conversation

@xiaocwan
Copy link
Contributor

@xiaocwan xiaocwan commented Apr 4, 2019

Now since 'challenge' and 'login' are removed from identityProviders, update the test template for integration test.

oauthConfig:
  ...
  identityProviders:
  - name: "my_ldap_provider" 
    challenge: true 
    login: true

@spadgett Could you help to review please? Thanks!

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocwan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jhadvig

If they are not already assigned, you can assign the PR to them by writing /assign @jhadvig in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@xiaocwan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console 4f78bbc link /test e2e-aws-console
ci/prow/e2e-aws 4f78bbc link /test e2e-aws
ci/prow/e2e-aws-console-olm 4f78bbc link /test e2e-aws-console-olm
ci/prow/images 4f78bbc link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xiaocwan
Copy link
Contributor Author

xiaocwan commented Apr 4, 2019

Duplicated to #1342, closing this one.

@xiaocwan xiaocwan closed this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants