Skip to content

Auth test updates #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 6, 2019
Merged

Auth test updates #1342

openshift-merge-robot merged 1 commit into from
Apr 6, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Mar 26, 2019

  • login and challenge are no longer in the API
  • Prefix test env vars with BRIDGE
  • Update README for recent changes

/cc @enj @TheRealJon

@xiaocwan fyi

@spadgett
Auth test updates
386e353 
* `login` and `challenge` are no longer in the API
* Prefix test env vars with `BRIDGE`
* Update README for recent changes
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2019
@spadgett
Copy link
Member Author

spadgett commented Mar 26, 2019

See openshift/api#265

@spadgett
Copy link
Member Author

spadgett commented Mar 27, 2019

/retest

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Mar 27, 2019

/retest

@spadgett spadgett changed the title [WIP] Auth test updates Auth test updates Apr 2, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

@TheRealJon ptal

@xiaocwan xiaocwan mentioned this pull request Apr 4, 2019
Closed
TheRealJon
TheRealJon reviewed Apr 4, 2019
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/test e2e-aws-console

@spadgett spadgett added this to the v4.1 milestone Apr 5, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/test e2e-aws-console

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b15c43d into openshift:master Apr 6, 2019
@spadgett spadgett deleted the auth-test-updates branch April 6, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon TheRealJon left review comments

@enj enj Awaiting requested review from enj

Assignees

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@spadgett @openshift-ci-robot @openshift-bot @TheRealJon @openshift-merge-robot