Update OAuth API #265
Merged
Update OAuth API #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields offer a level of flexibility that is not particularly useful to admins. In reality all IDPs have a correct configuration for these fields based on the feature set that the IDP supports. We should avoid asking users questions that we already know the answer to. Signed-off-by: Monis Khan <mkhan@redhat.com>
This change adds an issuer field which can be used to perform discovery via the /.well-known/openid-configuration endpoint. This makes the OpenIDURLs struct obsolete. Signed-off-by: Monis Khan <mkhan@redhat.com>
openshift-ci-robot
added
the
size/S
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, enj, mrogers950 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This was referenced Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infer challenge and login based on IDP
These fields offer a level of flexibility that is not particularly
useful to admins. In reality all IDPs have a correct configuration
for these fields based on the feature set that the IDP supports. We
should avoid asking users questions that we already know the answer
to.
Signed-off-by: Monis Khan mkhan@redhat.com
Add issuer to OpenIDIdentityProvider
This change adds an issuer field which can be used to perform
discovery via the /.well-known/openid-configuration endpoint. This
makes the OpenIDURLs struct obsolete.
Signed-off-by: Monis Khan mkhan@redhat.com
@openshift/sig-auth
/assign @derekwaynecarr
These changes are already handled in openshift/cluster-authentication-operator#99