Removing login and challenge parameters #14560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Contributor
Author
|
Removing cc @huffmanca FYI |
Member
|
lgtm, but would be good to have @enj review |
enj
reviewed
Apr 23, 2019
| name: idp-secret | ||
| claims: <7> | ||
| claims: <5> | ||
| preferredUsername: | ||
| - preferred_username | ||
| name: | ||
| - name | ||
| email: | ||
| urls: |
There was a problem hiding this comment.
urls was dropped openshift/api#265 and replaced with issuer
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that! This is now updated.
Contributor
Author
There was a problem hiding this comment.
Discussed this with @huffmanca and he will provide further edits in a follow-up PR
|
LGTM, feel free to update OpenID in a different PR |
ahardin-rh
force-pushed
the
login-challenge-removal
branch
from
6ae855f to
c2fbf78
Compare
huffmanca
added
the
peer-review-done
Contributor
|
This looks good to me! I'll handle OpenID in a separate PR. |
Contributor
Author
|
@stuartchuan Can you please provide QE review? |
Contributor
Author
|
@barleyer Can you please provide QE review? |
|
/lgtm Need an another PR to update openid |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1693431