Skip to content

Upgrade Chrome and Chromedriver #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Apr 5, 2019
Merged

Upgrade Chrome and Chromedriver #1383

openshift-merge-robot merged 2 commits into from
Apr 5, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 4, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2019
@spadgett spadgett force-pushed the upgrade-chromedriver branch from cb14e14 to ab9f997 Compare April 4, 2019 14:04
@spadgett
Copy link
Member Author

spadgett commented Apr 4, 2019

OK, looks like we need to update Chrome in the image to use this:

[14:45:52] E/launcher - session not created: Chrome version must be between 71 and 75
  (Driver info: chromedriver=2.46.628388 (4a34a70827ac54148e092aafb70504c4ea7ae926),platform=Linux 3.10.0-957.1.3.el7.x86_64 x86_64)
[14:45:52] E/launcher - SessionNotCreatedError: session not created: Chrome version must be between 71 and 75
  (Driver info: chromedriver=2.46.628388 (4a34a70827ac54148e092aafb70504c4ea7ae926),platform=Linux 3.10.0-957.1.3.el7.x86_64 x86_64)

@spadgett spadgett changed the title Upgrade chromedriver to 2.46.0 Upgrade Chrome and Chromedriver Apr 4, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 4, 2019

@alecmerdler FYI, I'm also upgrading Chrome in our builder image

@spadgett spadgett mentioned this pull request Apr 4, 2019
Merged
@spadgett spadgett changed the title Upgrade Chrome and Chromedriver [WIP] Upgrade Chrome and Chromedriver Apr 4, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

Requires openshift/release#3359

@spadgett spadgett mentioned this pull request Apr 5, 2019
Merged
@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/retest

@spadgett spadgett changed the title [WIP] Upgrade Chrome and Chromedriver Upgrade Chrome and Chromedriver Apr 5, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

It failed, but Chrome didn't crash! This looks like an unrelated flake.

StaleElementReferenceError: stale element reference: element is not attached to the page document
  (Session info: headless chrome=73.0.3683.86)
  (Driver info: chromedriver=2.46.628388 (4a34a70827ac54148e092aafb70504c4ea7ae926),platform=Linux 3.10.0-957.1.3.el7.x86_64 x86_64)

/retest

jhadvig
jhadvig approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

More stale element reference errors, but it got past the OperatorHub tests.

StaleElementReferenceError: stale element reference: element is not attached to the page document
  (Session info: headless chrome=73.0.3683.86)
  (Driver info: chromedriver=2.46.628388 (4a34a70827ac54148e092aafb70504c4ea7ae926),platform=Linux 3.10.0-957.1.3.el7.x86_64 x86_64)

/skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019 •
edited
Loading

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm eeba90a link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit e6c12a8 into openshift:master Apr 5, 2019
@spadgett spadgett deleted the upgrade-chromedriver branch April 5, 2019 17:03
@spadgett spadgett mentioned this pull request Apr 5, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spadgett @openshift-ci-robot @jhadvig @openshift-merge-robot