-
Notifications
You must be signed in to change notification settings - Fork 667
Temporarily disable broken secret scenario tests #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable broken secret scenario tests #1386
Conversation
|
/retest |
|
@spadgett yeah, will take a closer look on what could be the possible cause of the issue. Lets skip these test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HmmHmm so when I was checking the failed test in #1381 I can see:
Interacting with the create secret forms.Key/Value secrets check for edited Key/Value secret values 0.30s
Error: Failed expectation
at Object.<anonymous> (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:67:29)
at step (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:32:23)
at Object.next (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:13:53)
at fulfilled (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:4:58)
at process._tickCallback (internal/process/next_tick.js:68:7)
So not sure that disabling the Registry credentials image secrets test will help. Probably there is something either wrong with the test itself or the create-secret form.
Taking a closer look
|
/hold We've updated Chrome to the latest version in CI. Previously we were using an older beta version (at the time it was required for |
|
ok... if anything we can disable all the secret tests temporarily, already looking into it. |
d2c62c2 to
d338d6e
Compare
d338d6e to
da97d31
Compare
|
/hold cancel |
jhadvig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold e2e-aws-console passed in #1383. Just want to double-check that this is still needed after that merges. |
|
@spadgett: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
/hold cancel Secret tests are still failing (just not every run) |
Disable secret scenario which is failing almost every run.