Skip to content

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 5, 2019

Disable secret scenario which is failing almost every run.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 5, 2019
@openshift openshift deleted a comment from openshift-ci-robot Apr 5, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/assign @jhadvig

We should debug the secret test. I was hoping #1385 would fix it, but no luck.

I'm upgrading Chrome to try and avoid the OperatorHub crash in #1383

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/retest

@jhadvig
Copy link
Member

jhadvig commented Apr 5, 2019

@spadgett yeah, will take a closer look on what could be the possible cause of the issue. Lets skip these test.
Also I see that the performance tests are failing pretty often.

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HmmHmm so when I was checking the failed test in #1381 I can see:

Interacting with the create secret forms.Key/Value secrets check for edited Key/Value secret values 0.30s

Error: Failed expectation
    at Object.<anonymous> (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:67:29)
    at step (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:32:23)
    at Object.next (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:13:53)
    at fulfilled (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:4:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

So not sure that disabling the Registry credentials image secrets test will help. Probably there is something either wrong with the test itself or the create-secret form.
Taking a closer look

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/hold

We've updated Chrome to the latest version in CI. Previously we were using an older beta version (at the time it was required for --headless). Let's see if it fixes OperatorHub tests.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@jhadvig
Copy link
Member

jhadvig commented Apr 5, 2019

ok... if anything we can disable all the secret tests temporarily, already looking into it.

@spadgett spadgett force-pushed the disable-image-secret-test branch from d2c62c2 to d338d6e Compare April 5, 2019 12:09
@spadgett spadgett force-pushed the disable-image-secret-test branch from d338d6e to da97d31 Compare April 5, 2019 12:20
@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/hold

e2e-aws-console passed in #1383. Just want to double-check that this is still needed after that merges.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm da97d31 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/skip

@spadgett spadgett changed the title Temporarily disable broken e2e tests Temporarily disable broken secret scenario tests Apr 5, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/hold cancel

Secret tests are still failing (just not every run)

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 65b6285 into openshift:master Apr 5, 2019
@spadgett spadgett mentioned this pull request Apr 5, 2019
2 tasks
@spadgett spadgett deleted the disable-image-secret-test branch June 1, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants