Skip to content

Correctly handle batch calls to setState when creating secrets #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 5, 2019
Merged

Correctly handle batch calls to setState when creating secrets #1385

openshift-merge-robot merged 1 commit into from
Apr 5, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 4, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 4, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Apr 4, 2019

/test e2e-aws-console

@spadgett spadgett mentioned this pull request Apr 5, 2019
Merged
jhadvig
jhadvig approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spadgett, the changes are looking good. Although Im not really sure why the Registry credentials image secrets check for edited registry credentials image secret value step is failing.
Tested the change locally by running the tests but haven't hit the issue :-/
Not sure if we want to merge it or do some additional investigation.

frontend/public/components/secrets/create-secret.tsx
onChange(this.state, id);
};

onAddressChanged: React.ReactEventHandler<HTMLInputElement> = event => {
Copy link
Member

@jhadvig jhadvig Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking down the changeData method makes sense 👍 more clear this way

@jhadvig
Copy link
Member

jhadvig commented Apr 5, 2019 

Interacting with the create secret forms.Registry credentials image secrets check for edited registry credentials image secret value 0.32s

Error: Failed expectation
    at Object.<anonymous> (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:67:29)
    at step (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:32:23)
    at Object.next (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:13:53)
    at fulfilled (/go/src/github.com/openshift/console/frontend/integration-tests/views/secrets.view.ts:4:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

/retest

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

Although Im not really sure why the Registry credentials image secrets check for edited registry credentials image secret value step is failing.

Yeah, that is failing on almost every PR :(

dtaylor113
dtaylor113 approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

Adding lgtm label based on approved reviews from Jakub and Dave.

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2019

/retest

@spadgett spadgett added this to the v4.1 milestone Apr 5, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019 •
edited
Loading

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm c4d2af5 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 89d52b4 into openshift:master Apr 5, 2019
@spadgett spadgett deleted the create-secret-set-state branch April 6, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

+1 more reviewer

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@spadgett @jhadvig @openshift-ci-robot @dtaylor113 @openshift-merge-robot