Skip to content

Bugzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained... #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 5, 2019
Merged

Bugzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained... #1384

openshift-merge-robot merged 1 commit into from
Apr 5, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 4, 2019

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2019
@rhamilto rhamilto changed the title [WIP] Buzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained... Buzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained... Apr 4, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2019
@rhamilto rhamilto changed the title Buzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained... Bugzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained... Apr 4, 2019
sg00dwin
sg00dwin approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Apr 4, 2019

/skip
/test e2e-aws-console

@spadgett
Copy link
Member

spadgett commented Apr 5, 2019

/test e2e-aws-console

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019 •
edited
Loading

@rhamilto: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 8ebae04 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhamilto
Copy link
Member Author

rhamilto commented Apr 5, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 668c310 into openshift:master Apr 5, 2019
@rhamilto rhamilto deleted the safari-12.1-scroll-bug-2 branch April 5, 2019 14:39
@rhamilto rhamilto mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sg00dwin sg00dwin sg00dwin approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@spadgett spadgett

@sg00dwin sg00dwin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @spadgett @sg00dwin @openshift-merge-robot