Skip to content

Bugzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained... #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Apr 5, 2019
Merged

Bugzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained... #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion frontend/public/style/_overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,16 +276,29 @@ tags-input .autocomplete .suggestion-item em {
}

.pf-c-page {
display: block !important;
position: relative;

&__header {
background-color: var(--pf-global--BackgroundColor--dark-200);
background-image: url("../imgs/pfbg_2000.jpg");
background-repeat: no-repeat;
background-size: cover;
left: 0;
position: absolute;
right: 0;
top: 0;
}

&__main {
// `z-index: auto` is required for fullscreen terminal
--pf-c-page__main--ZIndex: auto;
bottom: 0;
position: absolute;
left: 0;
right: 0;
top: var(--pf-c-page__header--MinHeight);
transition: left 100ms ease;
}

// `.pf-c-page` specificity required
Expand All @@ -301,11 +314,20 @@ tags-input .autocomplete .suggestion-item em {
}
}

@media screen and (min-width: $grid-float-breakpoint) {
.pf-m-expanded + .pf-c-page__main {
left: var(--pf-c-page__sidebar--md--Width);
}
}

.pf-c-page__sidebar {
--pf-c-page__sidebar--BackgroundColor: #{$color-pf-black-900};
--pf-c-page__sidebar--PaddingBottom: 0;
--pf-c-page__sidebar--PaddingTop: 0;
position: relative; // fix z-index bug in Edge
bottom: 0;
left: 0;
position: absolute;
top: var(--pf-c-page__header--MinHeight);
width: 0 !important; // only set size when expanded (.pf-m-expanded is added)

@media screen and (min-width: $grid-float-breakpoint) {
Expand Down