Skip to content

Cleanup up branding so there is consistency among the product name #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 5, 2019
Merged

Cleanup up branding so there is consistency among the product name #1389

openshift-merge-robot merged 1 commit into from
Apr 5, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 5, 2019

  • standardize product names to include "Red Hat" and reduce the number of places product name is declared
  • remove product name from the about modal as it is redundant with the logo above
  • remove orphaned props from about modal

@rhamilto
Cleanup up branding so there is consistency among the product name
bf6f643 
* standardize product names to include "Red Hat" and reduce the number of places product name is declared
* remove product name from the about modal as it is redundant with the logo above
* remove orphaned props from about modal
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2019
spadgett
spadgett approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Apr 5, 2019

This is a bug fix since titles were previously inconsistent.

@spadgett spadgett added this to the v4.1 milestone Apr 5, 2019
@rhamilto rhamilto mentioned this pull request Apr 5, 2019
Merged
@spadgett
Copy link
Member

spadgett commented Apr 5, 2019

/test e2e-aws-console

@openshift-merge-robot openshift-merge-robot merged commit 7a28d42 into openshift:master Apr 5, 2019
@rhamilto rhamilto deleted the branding-cleanup branch April 8, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamilto @openshift-ci-robot @spadgett @openshift-merge-robot