Skip to content

Add option for custom branding #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 9, 2019
Merged

Add option for custom branding #1391

openshift-merge-robot merged 1 commit into from
May 9, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 5, 2019 •
edited
Loading 

./bin/bridge --custom-product-name="Lorem Ipsum" --custom-logo-file="/path/to/img.ext"

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 5, 2019
@rhamilto rhamilto force-pushed the console-branding branch 4 times, most recently from 6f54f9d to 9eff536 Compare April 5, 2019 20:56
@spadgett spadgett added this to the v4.2 milestone Apr 7, 2019
@rhamilto rhamilto force-pushed the console-branding branch 3 times, most recently from 60c61e2 to fe8c93c Compare April 8, 2019 20:00
benjaminapetersen
benjaminapetersen reviewed Apr 8, 2019
View reviewed changes
benjaminapetersen
benjaminapetersen reviewed Apr 8, 2019
View reviewed changes
@rhamilto rhamilto force-pushed the console-branding branch 2 times, most recently from a786f34 to 74e2446 Compare April 15, 2019 15:08
rhamilto
rhamilto commented Apr 17, 2019
View reviewed changes
@rhamilto rhamilto force-pushed the console-branding branch 2 times, most recently from a3549ce to 3b7b1ba Compare April 23, 2019 14:54
@rhamilto rhamilto force-pushed the console-branding branch from 3b7b1ba to 1fb3305 Compare May 2, 2019 14:57
@rhamilto rhamilto force-pushed the console-branding branch from 1fb3305 to e65d7d9 Compare May 6, 2019 12:38
spadgett
spadgett approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@spadgett spadgett changed the title [WIP] Add option for custom branding Add option for custom branding May 9, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented May 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented May 9, 2019

/retest

1 similar comment
@spadgett
Copy link
Member

spadgett commented May 9, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 64e9a5a into openshift:master-next May 9, 2019
@rhamilto rhamilto deleted the console-branding branch May 9, 2019 19:33
@zherman0 zherman0 mentioned this pull request May 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@sg00dwin sg00dwin Awaiting requested review from sg00dwin

+1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @spadgett @benjaminapetersen @openshift-merge-robot