Skip to content

Update UI for Degraded ClusterOperator condition#1437

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
spadgett:degraded
Apr 22, 2019
Merged

Update UI for Degraded ClusterOperator condition#1437
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
spadgett:degraded

Conversation

@spadgett
Copy link
Copy Markdown
Member

@spadgett spadgett commented Apr 16, 2019

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 16, 2019

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm fadf597 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Copy Markdown
Member Author

spadgett commented Apr 16, 2019

/skip

@spadgett spadgett added this to the v4.1 milestone Apr 16, 2019
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2019
rebeccaalpert
rebeccaalpert approved these changes Apr 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jhadvig
jhadvig reviewed Apr 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple of questions. Also shouldn't we wait for openshift/cluster-version-operator#165 ?

Comment thread frontend/public/components/cluster-settings/cluster-operator.tsx
Comment thread frontend/public/module/k8s/cluster-operator.ts
@spadgett
Copy link
Copy Markdown
Member Author

spadgett commented Apr 22, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2019
@openshift-merge-robot openshift-merge-robot merged commit e6aaa63 into openshift:master Apr 22, 2019
@spadgett spadgett deleted the degraded branch April 22, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig left review comments

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

+1 more reviewer

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rebeccaalpert rebeccaalpert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@spadgett @openshift-ci-robot @jhadvig @rebeccaalpert @openshift-merge-robot