Add ConsoleCLIDownload CRD extension

[rhamilto]

https://jira.coreos.com/browse/CONSOLE-1480

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: consoleclidownloads.console.openshift.io
  annotations:
    displayName: ConsoleCLIDownload
    description: Extension for configuring openshift web console command line interface (CLI) downloads.
spec:
  scope: Cluster
  group: console.openshift.io
  versions:
  - name: v1
    served: true
    storage: true
  names:
    plural: consoleclidownloads
    singular: consoleclidownload
    kind: ConsoleCLIDownload
    listKind: ConsoleCLIDownloadList
  additionalPrinterColumns:
  - name: Display name
    type: string
    JSONPath: .spec.displayName
  - name: Age
    type: string
    JSONPath: .metadata.creationTimestamp
  - name: Description
    type: string
    JSONPath: .spec.description
  subresources:
    status: {}
  validation:
    openAPIV3Schema:
      properties:
        spec:
          type: object
          description: Represents console CLI download spec
          required:
          - displayName
          - description
          - links
          properties:
            displayName:
              type: string
              description: Display name of the CLI download
            description:
              type: string
              description: Description of the CLI download (can include markdown)
            links:
              type: array
              description: Objects that hold CLI download link details
              nullable: true
              items:
                type: object
                required:
                - href
                properties:
                  text:
                    type: string
                    description: Text of the link
                  href:
                    type: string
                    description: Absolute secure URL for the link (must use https)
                    pattern: '^https://([\w-]+.)+[\w-]+(/[\w- ./?%&=])?$'

[jhadvig]

@rhamilto looks great! Just couple of comments :)

[rhamilto]

Just discovered a bug and am not sure how to fix. If the CRD has not been registered with the cluster, the page contents don't render since firehose cannot get resources that don't have a model registered.

No model registered for console.openshift.io~v1~ConsoleCLIDownload

@spadgett, how do I fix?

[rhamilto]

/retest

[rhamilto]

/retest

[rhamilto]

/retest

[spadgett]

Suggested change

	const CommandLineTools = ({obj}) => {
	const CommandLineTools: React.FC<CommandLineToolsProps> = ({obj}) => {

then

type CommandLineToolsProps = {
  obj: FirehoseResult;
};

[rhamilto]

@spadgett, PR updated and ready for merge.

[spadgett]

/lgtm

[rhamilto]

@spadgett Rebased. Please tag again.

[spadgett]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

infrastructure failure

/retest