Add ConsoleNotification CRD that can appear above, below, or above and below the page #1542

rhamilto · 2019-05-07T15:18:39Z

https://jira.coreos.com/browse/CONSOLE-1452

Differs from #1325 in that there is no dismiss option per @spadgett's desire to keep the initial implementation as simple as possible.

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: consolenotifications.console.openshift.io
  annotations:
    displayName: ConsoleNotification
    description: Extension for configuring openshift web console notifications.
spec:
  scope: Cluster
  group: console.openshift.io
  versions:
  - name: v1
    served: true
    storage: true
  names:
    plural: consolenotifications
    singular: consolenotification
    kind: ConsoleNotification
    listKind: ConsoleNotificationList
  additionalPrinterColumns:
  - name: Text
    type: string
    JSONPath: .spec.text
  - name: Location
    type: string
    JSONPath: .spec.location
  - name: Age
    type: date
    JSONPath: .metadata.creationTimestamp
  subresources:
    status: {}
  validation:
    openAPIV3Schema:
      properties:
        spec:
          type: object
          description: Represents console notification spec
          required:
          - text
          - location
          properties:
            text:
              type: string
              description: Text of the notification
            location:
              type: string
              description: The location of the notification (BannerTop, BannerBottom, BannerTopBottom)
              pattern: '^(BannerTop|BannerBottom|BannerTopBottom)$'
            link:
              type: object
              description: Object that holds notification link details
              required:
              - href
              - text
              properties:
                text:
                  type: string
                  description: Text of the link
                href:
                  type: string
                  description: Absolute secure URL for the link (must use https)
                  pattern: '^https://([\w-]+.)+[\w-]+(/[\w- ./?%&=])?$'
            backgroundColor:
              type: string
              description:  The background color for the notification as CSS data type color
            color:
              type: string
              description:  The color of the text for the notification as CSS data type color

extensions/console-notification.crd.yaml

frontend/public/components/console-notifier.tsx

- Related to openshift/console#1542

extensions/console-notification.crd.yaml

frontend/public/components/console-notifier.tsx

- Related to openshift/console#1542

rhamilto · 2019-05-29T14:39:07Z

/retest

rhamilto · 2019-05-29T17:15:34Z

/retest

- Related to openshift/console#1542

rhamilto · 2019-06-19T19:13:58Z

/retest

openshift-bot · 2019-06-27T18:11:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-06-27T19:42:47Z

/retest

openshift-bot · 2019-06-28T00:41:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-28T00:54:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-28T01:07:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-28T01:20:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-06-28T01:21:34Z

/hold
to avoid retest until rebased

rhamilto · 2019-06-28T13:07:34Z

@spadgett, rebased for what I hope is the last time. Please tag.

spadgett · 2019-06-28T15:07:25Z

/lgtm
/hold cancel

openshift-ci-robot · 2019-06-28T15:07:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-06-28T18:51:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

rhamilto · 2019-06-28T19:08:00Z

/retest

rhamilto · 2019-06-28T19:31:10Z

/retest

openshift-bot · 2019-06-28T19:31:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-28T20:41:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-06-28T21:21:26Z

/hold

level=error msg="Error: [ERR]: Error building changeset: InvalidChangeBatch: [Tried to create resource record set [name='api.ci-op-gm2jltp2-60667.origin-ci-int-aws.dev.rhcloud.com.', type='A'] but it already exists]"

Let's hold the PR to prevent retest until the test namespace is deleted. (Feel free to unhold later.)

alecmerdler · 2019-06-29T05:05:22Z

/retest

spadgett · 2019-06-29T13:51:04Z

Test completed successfully, but it couldn't get the logs after :(

2019/06/29 06:13:21 Container test in pod e2e-aws completed successfully
2019/06/29 06:13:22 error: unable to gather container logs: [error: Unable to retrieve logs from pod container artifacts: pods "e2e-aws" not found, error: Unable to retrieve logs from pod container setup: pods "e2e-aws" not found, error: Unable to retrieve logs from pod container teardown: pods "e2e-aws" not found, error: Unable to retrieve logs from pod container test: pods "e2e-aws" not found]

/hold cancel
/retest

openshift-ci-robot requested review from benjaminapetersen and jhadvig May 7, 2019 15:19

rhamilto changed the title ~~[WIP] Add ConsoleNotification CRD that can appear above or below the page~~ [WIP] Add ConsoleNotification CRD that can appear above, below, or above and below the page May 7, 2019

rhamilto mentioned this pull request May 7, 2019

[WIP] Add ConsoleNotification CRD that can appear above, below, or above and below the page with option to dismiss #1325

Closed

1 task

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2019

rhamilto force-pushed the console-notification-crd branch from 6b7a111 to d166bf5 Compare May 13, 2019 14:06

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2019

spadgett changed the base branch from master-next to master May 13, 2019 22:43

spadgett added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 14, 2019

rhamilto force-pushed the console-notification-crd branch from d166bf5 to 5fff460 Compare May 15, 2019 12:40

rhamilto commented May 15, 2019

View reviewed changes

extensions/console-notification.crd.yaml Outdated Show resolved Hide resolved

rhamilto commented May 15, 2019

View reviewed changes

frontend/public/components/console-notifier.tsx Outdated Show resolved Hide resolved

rhamilto force-pushed the console-notification-crd branch 2 times, most recently from fec6eb1 to d5d5960 Compare May 15, 2019 14:55

benjaminapetersen added a commit to benjaminapetersen/console-operator that referenced this pull request May 16, 2019

Add manifest for ConsoleNotification CRD

35e429c

- Related to openshift/console#1542

This was referenced May 16, 2019

Add console extension manifests openshift/console-operator#229

Merged

Add api types for console extension resources and console server config openshift/api#318

Merged

benjaminapetersen suggested changes May 20, 2019

View reviewed changes

extensions/console-notification.crd.yaml Outdated Show resolved Hide resolved

frontend/public/components/console-notifier.tsx Outdated Show resolved Hide resolved

benjaminapetersen added a commit to benjaminapetersen/console-operator that referenced this pull request May 21, 2019

Add manifest for ConsoleNotification CRD

0e8c775

- Related to openshift/console#1542

spadgett added this to the v4.2 milestone May 27, 2019

rhamilto force-pushed the console-notification-crd branch from d5d5960 to d457716 Compare May 29, 2019 13:16

rhamilto force-pushed the console-notification-crd branch from d457716 to 8eddcba Compare May 29, 2019 15:00

benjaminapetersen added a commit to benjaminapetersen/console-operator that referenced this pull request Jun 4, 2019

Add manifest for ConsoleNotification CRD

fd46af1

- Related to openshift/console#1542

rhamilto force-pushed the console-notification-crd branch from 8eddcba to fcb2a00 Compare June 19, 2019 18:02

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2019

spadgett mentioned this pull request Jun 27, 2019

Convert dropdowns and related inputs to pf4 #1751

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2019

Add ConsoleNotification CRD

7f21e82

rhamilto force-pushed the console-notification-crd branch from f827a05 to 7f21e82 Compare June 28, 2019 13:07

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2019

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 28, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2019

openshift-merge-robot merged commit fb86335 into openshift:master Jun 29, 2019

rhamilto deleted the console-notification-crd branch July 1, 2019 12:47

Add ConsoleNotification CRD that can appear above, below, or above and below the page #1542

Add ConsoleNotification CRD that can appear above, below, or above and below the page #1542

Uh oh!

Conversation

rhamilto commented May 7, 2019 • edited by spadgett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rhamilto commented May 29, 2019

Uh oh!

rhamilto commented May 29, 2019

Uh oh!

rhamilto commented Jun 19, 2019

Uh oh!

openshift-bot commented Jun 27, 2019

Uh oh!

spadgett commented Jun 27, 2019

Uh oh!

openshift-bot commented Jun 28, 2019

Uh oh!

openshift-bot commented Jun 28, 2019

Uh oh!

openshift-bot commented Jun 28, 2019

Uh oh!

openshift-bot commented Jun 28, 2019

Uh oh!

spadgett commented Jun 28, 2019

Uh oh!

rhamilto commented Jun 28, 2019

Uh oh!

spadgett commented Jun 28, 2019

Uh oh!

openshift-ci-robot commented Jun 28, 2019

Uh oh!

openshift-bot commented Jun 28, 2019

Uh oh!

rhamilto commented Jun 28, 2019

Uh oh!

rhamilto commented Jun 28, 2019

Uh oh!

openshift-bot commented Jun 28, 2019

Uh oh!

openshift-bot commented Jun 28, 2019

Uh oh!

spadgett commented Jun 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alecmerdler commented Jun 29, 2019

Uh oh!

spadgett commented Jun 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rhamilto commented May 7, 2019 •

edited by spadgett

Loading

spadgett commented Jun 28, 2019 •

edited

Loading