Upgrade React and Use Hooks #1456
Conversation
openshift-ci-robot
added
approved
|
Nice! |
alecmerdler
force-pushed
the
CONSOLE-1287
branch
from
32f854f to
e3741c7
Compare
| import k8sReducers from './module/k8s/k8s-reducers'; | ||
| import UIReducers from './ui/ui-reducers'; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Curious if it would be helpful to make it a separate file here, redux-thunk.js just to make this really really obvious (should anyone care).
|
I'm assuming the desired direction forward is to use |
| @@ -0,0 +1,43 @@ | |||
| /* eslint-disable no-undef, no-unused-vars */ | |||
There was a problem hiding this comment.
Thank you for adding all of the new tests!
| /** @type {React.SFC<{namespace: K8sResourceKind}>} */ | ||
| export const PullSecret = (props) => { | ||
| const [isLoading, setIsLoading] = React.useState(true); | ||
| const [data, setData] = React.useState(undefined); |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spadgett
added
the
kind/dependency-change
6 participants
Description
Upgrade React to use hooks instead of class components. Refactors some components to be examples of how to use and test React hooks.
Changes
<DownloadButton>,<CopyToClipboard>,<PullSecret>to be functional components withuseState()and added tests<Timestamp>to be stateless functional component and movedsetInterval()logic to Reduxextend PromiseComponent(rewritten in TypeScript)Next Steps
useSafetyFirstcustom hook to replaceextend SafetyFirstAddresses https://jira.coreos.com/browse/CONSOLE-1287