Skip to content

Add cluster operator start guide #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 29, 2019
Merged

Add cluster operator start guide #1486

openshift-merge-robot merged 1 commit into from
Apr 29, 2019

Conversation

@rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Apr 24, 2019

Added start guide per UX's design.

Screen Shot 2019-04-24 at 2 19 58 PM

Fixes CONSOLE-1404.

@openshift/team-ux-review, can you please review? Thanks!

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2019
spadgett
spadgett requested changes Apr 24, 2019
View reviewed changes
@bmignano
Copy link

bmignano commented Apr 25, 2019

LGTM @rebeccaalpert !

@spadgett spadgett added this to the v4.2 milestone Apr 25, 2019
ncameronbritt
ncameronbritt reviewed Apr 25, 2019
View reviewed changes
frontend/public/components/cluster-settings/cluster-operator-start-guide.tsx Outdated
Copy link

@ncameronbritt ncameronbritt Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the message here could be tightened up. IMHO it doesn't need to be totally comprehensive since we're pointing users to the docs anyway.

Cluster Operators automate updates of OpenShift and Kubernetes at the cluster level. During an update, the latest component versions downloaded and installed. To learn more about this process, read about Operators.

I don't want to block this PR, but we are going to discuss from a design perspective when using these blue boxes makes sense vs using an infopop, as in #1431.

Copy link
Member

@spadgett spadgett Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block this PR, but we are going to discuss from a design perspective when using these blue boxes makes sense vs using an infopop, as in #1431.

It would be good to find a pattern we could use on other pages. I think describing what a resource is makes sense for most resources, but the blue box at the top of every page would be too much.

Copy link
Contributor Author

@rebeccaalpert rebeccaalpert Apr 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still want to change the message given that we're not including the link right now?

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 25, 2019 •
edited
Loading

I reworked StartGuide to be reusable and use hooks. I also removed the link to the docs per Sam's comment.

Screen Shot 2019-04-25 at 2 36 36 PM

spadgett
spadgett requested changes Apr 25, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2019
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 26, 2019

/retest

spadgett
spadgett reviewed Apr 29, 2019
View reviewed changes
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 29, 2019

Addressed PR feedback.

spadgett
spadgett approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please squash. thanks!

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2019
@rebeccaalpert rebeccaalpert force-pushed the cluster-settings-start-guide branch from d90c9cc to ec18bd3 Compare April 29, 2019 18:35
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 29, 2019

Squashed!

spadgett
spadgett approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 29, 2019

/retest

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 29, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 2a42cb5 into openshift:master-next Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

@zherman0 zherman0 Awaiting requested review from zherman0

+1 more reviewer

@ncameronbritt ncameronbritt ncameronbritt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@rebeccaalpert @bmignano @openshift-ci-robot @spadgett @ncameronbritt @openshift-merge-robot