Skip to content

Route Details: Added canonical router hostname and popover help #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 15, 2019
Merged

Route Details: Added canonical router hostname and popover help #1431

openshift-merge-robot merged 1 commit into from
Apr 15, 2019

Conversation

@dtaylor113
Copy link
Contributor

@dtaylor113 dtaylor113 commented Apr 15, 2019

At the top of the page we are showing the ingress.status.routerCanonicalHostname for route.spec.host:
image
There may be multiple Routes listed in this sub-section, so showing 'custom DNS help' link for each:
image

The Popover:
image

*Is there an 'Learn more' link we can use in the popover?

Design Doc
Upstream PR: patternfly/patternfly-react#1757

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2019
@dtaylor113 dtaylor113 changed the title [WIP] Route Details: Added cononical router hostname and popover help [WIP] Route Details: Added canonical router hostname and popover help Apr 15, 2019
@dtaylor113 dtaylor113 mentioned this pull request Apr 15, 2019
Merged
@dtaylor113 dtaylor113 force-pushed the router-canonical-hostname branch from 1115207 to 37eb2bf Compare April 15, 2019 18:11
spadgett
spadgett requested changes Apr 15, 2019
View reviewed changes
@dtaylor113 dtaylor113 force-pushed the router-canonical-hostname branch from 37eb2bf to 9103208 Compare April 15, 2019 20:16
spadgett
spadgett requested changes Apr 15, 2019
View reviewed changes
@dtaylor113 dtaylor113 force-pushed the router-canonical-hostname branch 2 times, most recently from f8e4a23 to a96df4b Compare April 15, 2019 20:43
spadgett
spadgett approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@spadgett
Copy link
Member

spadgett commented Apr 15, 2019

still WIP?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@dtaylor113 dtaylor113 force-pushed the router-canonical-hostname branch from a96df4b to b90d8c4 Compare April 15, 2019 20:49
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@dtaylor113 dtaylor113 changed the title [WIP] Route Details: Added canonical router hostname and popover help Route Details: Added canonical router hostname and popover help Apr 15, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2019
@dtaylor113
Copy link
Contributor Author

dtaylor113 commented Apr 15, 2019 •
edited
Loading

@spadgett removed WIP label -thanks

spadgett
spadgett approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @dtaylor113

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@dtaylor113 dtaylor113 force-pushed the router-canonical-hostname branch from b90d8c4 to 7ca728b Compare April 15, 2019 21:09
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@dtaylor113
Copy link
Contributor Author

dtaylor113 commented Apr 15, 2019

@spadgett had to push a eslint fix

@spadgett
Copy link
Member

spadgett commented Apr 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Apr 15, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit b94aabc into openshift:master-next Apr 15, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 15, 2019

@dtaylor113: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 7ca728b link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncameronbritt ncameronbritt mentioned this pull request Apr 25, 2019
Merged
@spadgett spadgett added this to the v4.2 milestone Apr 26, 2019
@spadgett spadgett mentioned this pull request Jul 8, 2019
Closed
@dtaylor113 dtaylor113 deleted the router-canonical-hostname branch August 22, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@ncameronbritt ncameronbritt Awaiting requested review from ncameronbritt

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@dtaylor113 @spadgett @openshift-ci-robot @openshift-merge-robot