fix(popover): Enable highlighting and selecting text in popover. #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1757 +/- ##
=======================================
Coverage 82.72% 82.72%
=======================================
Files 598 598
Lines 6629 6629
Branches 72 72
=======================================
Hits 5484 5484
Misses 1118 1118
Partials 27 27
Continue to review full report at Codecov.
|
Member
Author
|
Hi @jschuler, @dlabaj, |
Member
Author
kmcfaul
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cursor does turn to I-Beam (text), but cannot highlight or select the text in the Popover:
With fix, can now highlight and select text:
Fixes #1735