CONSOLE-4720: update Workloads list pages to use ResourceDataView #15492

rhamilto · 2025-09-12T21:34:00Z

Duplicates changes also in #15489

This PR updates list views for the following Workloads:

public/components/hpa.tsx
public/components/job.tsx
public/components/pod.jsx
public/components/replicaset.jsx
public/components/replication-controller.jsx
public/components/stateful-set.tsx

openshift-ci-robot · 2025-09-12T21:34:04Z

@rhamilto: This pull request references CONSOLE-4720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Includes changes from #15469, which should merge first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

frontend/public/components/hpa.tsx

frontend/public/components/pod.tsx

openshift-ci-robot · 2025-09-30T14:03:53Z

@rhamilto: This pull request references CONSOLE-4720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-30T14:05:13Z

@rhamilto: This pull request references CONSOLE-4720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This PR updates list views for the following Workloads:

public/components/hpa.tsx

public/components/job.tsx

public/components/pod.jsx

public/components/replicaset.jsx

public/components/replication-controller.jsx

public/components/stateful-set.tsx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto · 2025-10-14T14:51:55Z

/label tide/merge-method-squash

rhamilto · 2025-10-14T15:08:45Z

/hold cancel

rhamilto · 2025-10-14T15:09:25Z

3905e76 restores the namespace column help text that was inadvertently omitted

TheRealJon

/lgtm

sferich888 · 2025-10-14T17:40:48Z

/label px-approved

TheRealJon · 2025-10-14T20:38:10Z

/lgtm

rhamilto · 2025-10-15T00:20:06Z

/retest

yapei · 2025-10-15T01:31:18Z

not sure why verified label got removed, tested again and confirmed working well
/verified by @yapei

openshift-ci-robot · 2025-10-15T01:31:30Z

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

not sure why verified label got removed, tested again and confirmed working well
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jseseCCS

Just a few comments but approved! will add approving label now.

jseseCCS · 2025-10-15T11:17:09Z

frontend/public/components/modals/column-management-modal.tsx

              >
-                {!columnLayout?.showNamespaceOverride &&
-                  t('public~The namespace column is only shown when in "All projects"')}
+                {!columnLayout?.showNamespaceOverride && <NamespaceColumnHelpText />}


Please confirm that renders same visible message shown here: “The namespace column is only shown when in ‘All projects’.” If wording/cap differs, I should review it for user-facing consistency/doc alignment.

The wording has not changed.

jseseCCS · 2025-10-15T11:19:47Z

frontend/public/components/cron-job.tsx

          kinds={['Pods']}
          ListComponent={PodList}
          rowFilters={podFilters}
+          hideColumnManagement={true}


Please confirm that setting hideColumnManagement and omitFilterToolbar removes those controls from CronJob list page. If any visible UI elements (column selector, filter bar) differ from prior behavior, I should review for user-facing consistency/doc alignment.

No differences.

jseseCCS · 2025-10-15T11:22:07Z

frontend/public/components/cron-job.tsx

        }}
        kinds={['Jobs']}
        ListComponent={JobsList}
+        hideColumnManagement={true}


ditto above: Confirm hideColumnManagement and omitFilterToolbar...

No differences.

jseseCCS · 2025-10-15T11:25:50Z

frontend/public/components/custom-resource-definition.tsx

          <span className="co-resource-item">
            <ResourceLink
-              kind="CustomResourceDefinition"
+              groupVersionKind={getGroupVersionKindForModel(CustomResourceDefinitionModel)}


Please confirm that replacing static "CustomResourceDefinition" string with {kind} and {getGroupVersionKindForModel(CustomResourceDefinitionModel)} doesn’t change any visible kind labels/kebab-menu behavior in CustomResourceDefinition list/detail views. If user-facing resource name or actions differ, I should review for consistency/doc alignment.

No differences.

jseseCCS · 2025-10-15T11:34:35Z

frontend/public/components/hpa.tsx

-      </TableData>
-    </>
-  );
+    const rowCells = {


Please confirm that refactoring HPA list rows to use rowCells + ResourceLink doesn’t change visible table behavior/row actions. If any column layout or kebab-menu options differ, I should review for user-facing consistency/doc alignment.

jseseCCS · 2025-10-15T11:36:40Z

frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts

    }
    describe(kind, () => {
      const name = `${testName}-${_.kebabCase(kind)}`;
+      const isDataViewResource = dataViewResources.has(kind);


Please confirm that adding isDataViewResource logic doesn’t affect expected UI behavior/labeling in resource CRUD tests. If any test-visible elements (resource names, menu options, form fields) differ between DataView/non-DataView resources, I should review for user-facing consistency/doc alignment.

No differences.

jseseCCS · 2025-10-15T11:38:56Z

frontend/packages/integration-tests-cypress/tests/crud/namespace-crud.cy.ts

-        listPage.filter.byName(text);
-        listPage.rows.countShouldBeWithin(1, 3);
-        listPage.rows.clickRowByName(text);
+        listPage.dvFilter.byName(text);


Please confirm that switching from filter/rows to dvFilter/dvRows doesn’t change user-visible filtering/table behavior on namespace CRUD pages. If any list-page controls, column visibility, selection options differ, I should review for user-facing consistency/doc alignment.

No differences.

jseseCCS · 2025-10-15T11:41:13Z

frontend/packages/integration-tests-cypress/views/list-page.ts

      cy.get('@filterDropdownToggleButton').click();
    },
  },
+  dvFilter: {


Please confirm that new dvFilter, dvRows helpers reflect same user-facing list interactions as prior filter/rows functions. If any visible list controls, filter options behave differently, I should review for user-facing consistency/doc alignment.

No differences.

openshift-ci · 2025-10-15T11:44:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jseseCCS, rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [TheRealJon,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jseseCCS · 2025-10-15T11:45:49Z

/label docs-approved

rhamilto · 2025-10-15T11:56:30Z

/retest

openshift-ci · 2025-10-15T16:11:49Z

@rhamilto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`0ea120c`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rhamilto · 2025-10-15T16:14:28Z

/retest

rhamilto · 2025-10-15T18:22:29Z

Changes are included in #15560, which will merge first.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2025

openshift-ci bot requested review from krishagarwal278 and sg00dwin September 12, 2025 21:34

openshift-ci bot added component/core Related to console core functionality kind/cypress Related to Cypress e2e integration testing approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 12, 2025

rhamilto force-pushed the CONSOLE-4720 branch from 1473ef9 to a1b853c Compare September 12, 2025 21:34

openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Sep 12, 2025

logonoff reviewed Sep 13, 2025

View reviewed changes

frontend/public/components/hpa.tsx Outdated Show resolved Hide resolved

frontend/public/components/hpa.tsx Outdated Show resolved Hide resolved

rhamilto force-pushed the CONSOLE-4720 branch 8 times, most recently from 801b835 to 9e43c49 Compare September 17, 2025 19:55

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2025

krishagarwal278 reviewed Sep 17, 2025

View reviewed changes

frontend/public/components/pod.tsx Show resolved Hide resolved

rhamilto force-pushed the CONSOLE-4720 branch from 9e43c49 to 67dd8f0 Compare September 18, 2025 00:11

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2025

rhamilto force-pushed the CONSOLE-4720 branch 2 times, most recently from 061cbe5 to 30942f0 Compare September 18, 2025 15:33

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2025

rhamilto force-pushed the CONSOLE-4720 branch from 30942f0 to 81aef5a Compare September 30, 2025 13:21

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 14, 2025

Restore namespace column help text to the column management modal

3905e76

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025

TheRealJon approved these changes Oct 14, 2025

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Oct 14, 2025

rhamilto mentioned this pull request Oct 14, 2025

CONSOLE-4724: Update Compute nav section to use ResourceDataView #15604

Merged

Integration test fix

0ea120c

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 15, 2025

jseseCCS approved these changes Oct 15, 2025

View reviewed changes

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Oct 15, 2025

rhamilto closed this Oct 15, 2025

logonoff deleted the CONSOLE-4720 branch October 15, 2025 18:29

CONSOLE-4720: update Workloads list pages to use ResourceDataView #15492

CONSOLE-4720: update Workloads list pages to use ResourceDataView #15492

Uh oh!

Conversation

rhamilto commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 12, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 30, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 30, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhamilto commented Oct 14, 2025

Uh oh!

rhamilto commented Oct 14, 2025

Uh oh!

rhamilto commented Oct 14, 2025

Uh oh!

TheRealJon left a comment

Choose a reason for hiding this comment

Uh oh!

sferich888 commented Oct 14, 2025

Uh oh!

TheRealJon commented Oct 14, 2025

Uh oh!

rhamilto commented Oct 15, 2025

Uh oh!

yapei commented Oct 15, 2025

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

jseseCCS left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Oct 15, 2025

Uh oh!

jseseCCS commented Oct 15, 2025

Uh oh!

rhamilto commented Oct 15, 2025

Uh oh!

openshift-ci bot commented Oct 15, 2025

Uh oh!

rhamilto commented Oct 15, 2025

rhamilto commented Sep 12, 2025 •

edited

Loading

openshift-ci-robot commented Sep 12, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 30, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 30, 2025 •

edited by openshift-ci bot

Loading