Skip to content

CONSOLE-4724: Update Compute nav section to use ResourceDataView #15604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Oct 22, 2025
Merged

CONSOLE-4724: Update Compute nav section to use ResourceDataView #15604

openshift-merge-bot merged 2 commits into from
Oct 22, 2025

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 14, 2025 •
edited
Loading

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 14, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4724 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 14, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4724 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Includes changes from #15492, #15560, #15567, and #15579 which should merge first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and jhadvig October 14, 2025 18:31
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 14, 2025
@rhamilto rhamilto changed the title [WIP] CONSOLE-4724: Update Compute nav section to use ResourceDataView CONSOLE-4724: Update Compute nav section to use ResourceDataView Oct 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4724 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 17, 2025

Adding labels as this is more of the same table migration work that has previously been approved.
/label docs-approved
/label px-approved

/assign @logonoff
/assign @yapei

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 17, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 17, 2025

/hold

I forgot to add counts to the Nodes filters

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 17, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 17, 2025

/test backend

@rhamilto
Copy link
Member Author

rhamilto commented Oct 18, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 20, 2025

/test okd-scos-e2e-aws-ovn

@yanpzhan
Copy link
Contributor

yanpzhan commented Oct 20, 2025 •
edited
Loading

@rhamilto Found some issues on the cluster launched against the pr.
The filter by type function didn't work as expected. Selecting filter by Roles/Architecture/Name/Label will switch back to filter by Status automatically.

Screencast.from.2025-10-20.21-14-04.mp4

The action dropdown list is empty for Machine/ControlPlaneMachineSets list pages.

Screencast.from.2025-10-20.21-27-31.mp4

@rhamilto
Copy link
Member Author

rhamilto commented Oct 20, 2025 •
edited
Loading

@rhamilto Found some issues on the cluster launched against the pr. The filter by type function didn't work as expected. Selecting filter by Roles/Architecture/Name/Label will switch back to filter by Status automatically.
Screencast.from.2025-10-20.21-14-04.mp4

Good catch, @yanpzhan! I believe I have fixed the issue. Note: this same behavior occurs on the Pods list page due to the inclusion of the counts in the filter options. This PR also includes a fix for the Pods list.

Bah. The counts are now incorrect (all show (0)). Need to investigate further.

/hold

I think we probably need to reconsider the inclusion of the count in the label filter. Any change to any count is going to cause the filters to reset because a change to any count results in the filter options re-rendering which results in the filters themselves re-rendering.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 20, 2025 •
edited
Loading

@rhamilto Found some issues on the cluster launched against the pr. The filter by type function didn't work as expected. Selecting filter by Roles/Architecture/Name/Label will switch back to filter by Status automatically.
Screencast.from.2025-10-20.21-14-04.mp4

Good catch, @yanpzhan! I believe I have fixed the issue. Note: this same behavior occurs on the Pods list page due to the inclusion of the counts in the filter options. This PR also includes a fix for the Pods list.

Bah. The counts are now incorrect (all show (0)). Need to investigate further.
/hold

I think we probably need to reconsider the inclusion of the count in the label filter. Any change to any count is going to cause the filters to reset because a change to any count results in the filter options re-rendering which results in the filters themselves re-rendering.

Confirmed. I've removed the counts from the Nodes and Pods Status filters. Let me know if you have questions, @yanpzhan. cc: @yapei

Screenshot 2025-10-20 at 6 30 04 PM Screenshot 2025-10-20 at 6 30 12 PM

@yapei
Copy link
Contributor

yapei commented Oct 21, 2025 •
edited
Loading

Confirmed. I've removed the counts from the Nodes and Pods Status filters. Let me know if you have questions,

ACK

@yanpzhan
Copy link
Contributor

yanpzhan commented Oct 21, 2025

Checked against the latest pr code again, there is not issue now.
/verified by @yanpzhan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2025

@yanpzhan: This PR has been marked as verified by @yanpzhan.

Details

In response to this:

Checked against the latest pr code again, there is not issue now.
/verified by @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/test backend

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/test okd-scos-e2e-aws-ovn

logonoff
logonoff approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2025

/retest-required

Remaining retests: 0 against base HEAD 199697f and 2 for PR HEAD ffff830 in total

@rhamilto
Copy link
Member Author

rhamilto commented Oct 21, 2025

/test frontend
/test okd-scos-e2e-aws-ovn

@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/test frontend
/test okd-scos-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 22, 2025

/retest-required

Remaining retests: 0 against base HEAD d553154 and 1 for PR HEAD ffff830 in total

@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 22, 2025

/retest-required

Remaining retests: 0 against base HEAD dd8daa7 and 0 for PR HEAD ffff830 in total

@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/test okd-scos-e2e-aws-ovn

3 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/test okd-scos-e2e-aws-ovn

@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/test okd-scos-e2e-aws-ovn

@rhamilto
Copy link
Member Author

rhamilto commented Oct 22, 2025

/test okd-scos-e2e-aws-ovn

@openshift-merge-bot openshift-merge-bot bot merged commit a79caa0 into openshift:main Oct 22, 2025
7 of 8 checks passed
@rhamilto rhamilto deleted the CONSOLE-4724 branch October 22, 2025 23:42
@rhamilto rhamilto mentioned this pull request Oct 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

1 more reviewer

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yapei yapei

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @yanpzhan @yapei @logonoff