Skip to content

CONSOLE-4718: Update Administrator nav section to use ConsoleDataView #15567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 5 commits into from
Oct 25, 2025
Merged

CONSOLE-4718: Update Administrator nav section to use ConsoleDataView #15567

openshift-merge-bot merged 5 commits into from
Oct 25, 2025

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 6, 2025 •
edited
Loading

Includes changes from #15622, which should merge first.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4718 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Includes changes from #15492 and #15560, which should merge first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2025
@openshift-ci openshift-ci bot requested review from TheRealJon and jhadvig October 6, 2025 20:52
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 6, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 7, 2025

/retest

2 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented Oct 7, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 7, 2025

/retest

@rhamilto rhamilto mentioned this pull request Oct 7, 2025
Merged
@rhamilto
Copy link
Member Author

rhamilto commented Oct 8, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 8, 2025

/retest

@rhamilto rhamilto force-pushed the CONSOLE-4718 branch 3 times, most recently from 26adb31 to aa10547 Compare October 9, 2025 17:02
@rhamilto
Copy link
Member Author

rhamilto commented Oct 13, 2025

/retest

@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Oct 13, 2025
@rhamilto rhamilto mentioned this pull request Oct 14, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4718 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Waiting for https://issues.redhat.com/browse/CONSOLE-4838 to be completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto force-pushed the CONSOLE-4718 branch 2 times, most recently from 9f6a120 to ec9827a Compare October 21, 2025 12:37
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4718 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Includes changes from #15622, which should merge first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 23, 2025

/retest

@yapei
Copy link
Contributor

yapei commented Oct 23, 2025

build errors need to be fixed first

@rhamilto
Copy link
Member Author

rhamilto commented Oct 23, 2025

/retest

@rhamilto rhamilto mentioned this pull request Oct 23, 2025
Closed
@rhamilto
Copy link
Member Author

rhamilto commented Oct 23, 2025

/retest

1 similar comment
@rhamilto
Copy link
Member Author

rhamilto commented Oct 23, 2025

/retest

@yapei
Copy link
Contributor

yapei commented Oct 24, 2025

confirmed the latest code is working as expected
/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

confirmed the latest code is working as expected
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member

logonoff commented Oct 24, 2025

/unhold
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Member

logonoff commented Oct 25, 2025 •
edited by openshift-ci bot
Loading

/retitle CONSOLE-4718: Update Administrator nav section to use ConsoleDataView

@openshift-ci openshift-ci bot changed the title [WIP] CONSOLE-4718: Update Administrator nav section to use ConsoleDataView CONSOLE-4718: Update Administrator nav section to use ConsoleDataView Oct 25, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2025
@logonoff
Copy link
Member

logonoff commented Oct 25, 2025

/label px-approved
/label docs-approved
/retest

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 25, 2025
@logonoff
Copy link
Member

logonoff commented Oct 25, 2025

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Oct 25, 2025

/hold cancel

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a7062ee into openshift:main Oct 25, 2025
8 checks passed
@logonoff logonoff deleted the CONSOLE-4718 branch October 25, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

2 more reviewers

@vojtechszocs vojtechszocs vojtechszocs left review comments

@yapei yapei yapei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rhamilto @openshift-ci-robot @yapei @logonoff @vojtechszocs @openshift-merge-robot